Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Callout - Fix Types #3

Merged
merged 3 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NATS.Jwt/Models/NatsClientInformation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/// </summary>
[JsonPropertyName("id")]
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)]
public string Id { get; set; }
public long Id { get; set; }

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / check

Symbol 'Id.get' is not part of the declared public API

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / check

Symbol 'Id.get' is not part of the declared public API

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (ubuntu-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (ubuntu-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (ubuntu-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (ubuntu-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (windows-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (windows-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (windows-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (windows-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (macos-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (macos-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (macos-latest)

Check failure on line 26 in NATS.Jwt/Models/NatsClientInformation.cs

View workflow job for this annotation

GitHub Actions / dotnet (macos-latest)

mtmk marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// Gets or sets the value representing the user property of the <see cref="NatsClientInformation"/> class.
Expand Down
2 changes: 1 addition & 1 deletion NATS.Jwt/NatsJwt.cs
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ public string EncodeAuthorizationRequestClaims(NatsAuthorizationRequestClaims au
/// <returns>The encoded string representation of the authorization response claims.</returns>
public string EncodeAuthorizationResponseClaims(NatsAuthorizationResponseClaims authorizationResponseClaims, KeyPair keyPair, DateTimeOffset? issuedAt = null)
{
SetVersion(authorizationResponseClaims.AuthorizationResponse, AuthorizationRequestClaim);
SetVersion(authorizationResponseClaims.AuthorizationResponse, AuthorizationResponseClaim);
return DoEncode(NatsJwtHeader, keyPair, authorizationResponseClaims, JsonContext.Default.NatsAuthorizationResponseClaims, issuedAt);
}

Expand Down
Loading