[FIX] pin nibabel version #800
Conversation
…ly through dcmstack
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #800 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 42 42
Lines 4323 4323
=======================================
Hits 3566 3566
Misses 757 757 ☔ View full report in Codecov by Sentry. |
|
looks like nibabel drop 3.8 support, should heudiconv do the same? @yarikoptic |
I guess we could. |
| @@ -27,7 +27,7 @@ | |||
| "dcmstack>=0.8", | |||
| "etelemetry", | |||
| "filelock>=3.0.12", | |||
| "nibabel", | |||
| "nibabel>=5.3.1", | |||
There was a problem hiding this comment.
remind me -- why we did not have that issue before? if that is just a buggy singular nibabel version - we better just exclude that one
There was a problem hiding this comment.
Forgot to note the version that was causing this issue before upgrading, but has been there for a while #455 (comment) and my environment wasn't that old. Also we had nipy/nibabel#1378 recently merge that solved failing tests.
There was a problem hiding this comment.
well, this is a fresh version released not even a month ago. Some distributions might not have it yet, and would cause troubles. I would just keep in mind that a recent nibabel is needed for processing enhanced dicoms?
May be even get some "catch all" handler that if exception happens and nibabel is below this version -- recommend upgrading?
to avoid a bunch of enhanced dicoms issues, notably through dcmstack.
eg.
should be fixed.