Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pin nibabel version #800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FIX] pin nibabel version #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9642024
pin nibabel version to avoid a bunch of enhanced dicoms issues, notab…
bpinsard Oct 31, 2024
a3d69d8
deprecate py3.8
bpinsard Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.9'

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
if: steps.auto-version.outputs.version != ''
uses: actions/setup-python@v5
with:
python-version: '^3.8'
python-version: '^3.9'

- name: Install Python dependencies
if: steps.auto-version.outputs.version != ''
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
fail-fast: false
matrix:
python-version:
- '3.8'
- '3.9'
- '3.10'
- '3.11'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.9'

- name: Install dependencies
run: |
Expand Down
5 changes: 2 additions & 3 deletions heudiconv/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,22 @@
"Environment :: Console",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Topic :: Scientific/Engineering",
"Typing :: Typed",
]

PYTHON_REQUIRES = ">=3.8"
PYTHON_REQUIRES = ">=3.9"

REQUIRES = [
# not usable in some use cases since might be just a downloader, not binary
# 'dcm2niix',
"dcmstack>=0.8",
"etelemetry",
"filelock>=3.0.12",
"nibabel",
"nibabel>=5.3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remind me -- why we did not have that issue before? if that is just a buggy singular nibabel version - we better just exclude that one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to note the version that was causing this issue before upgrading, but has been there for a while #455 (comment) and my environment wasn't that old. Also we had nipy/nibabel#1378 recently merge that solved failing tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this is a fresh version released not even a month ago. Some distributions might not have it yet, and would cause troubles. I would just keep in mind that a recent nibabel is needed for processing enhanced dicoms?

May be even get some "catch all" handler that if exception happens and nibabel is below this version -- recommend upgrading?

"nipype >=1.2.3",
"pydicom >= 1.0.0",
]
Expand Down