Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: nrf_modem v2.6.0 #14173

Closed
wants to merge 1 commit into from
Closed

manifest: nrf_modem v2.6.0 #14173

wants to merge 1 commit into from

Conversation

lemrey
Copy link
Contributor

@lemrey lemrey commented Feb 23, 2024 •
edited by eivindj-nordic
Loading

nrf_modem v2.6.0 release.
For a detail list of changes see the CHANGELOG file in nrfxlib.

sdk-nrfxlib PR: nrfconnect/sdk-nrfxlib#1227

@lemrey lemrey added this to the 2.6.0 milestone Feb 23, 2024
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest labels Feb 23, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 23, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@b02a54c (main) nrfconnect/sdk-nrfxlib#1227 nrfconnect/sdk-nrfxlib#1227/files
zephyr nrfconnect/sdk-zephyr@17d9e0f (main) nrfconnect/sdk-zephyr#1530 nrfconnect/sdk-zephyr#1530/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 23, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-boot X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_libmodem-nrf X
test-fw-nrfconnect-nrf-iot_lwm2m X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-thread X
test-low-level X
test-sdk-find-my X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@stig-bjorlykke stig-bjorlykke requested review from stig-bjorlykke and removed request for MarkusLassila and tomi-font February 23, 2024 17:47
MarkusLassila
MarkusLassila reviewed Feb 26, 2024
View reviewed changes
applications/serial_lte_modem/doc/SOCKET_AT_commands.rst
@@ -540,30 +540,31 @@ Syntax

* ``<value>`` is an integer that indicates the packet data network ID to bind to.

* ``50`` - :c:macro:`SO_RAI_NO_DATA` (set-only).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment: I think that it makes sense to remove these from the documentation. Given that these are deprecated, we will map the old values to new values in SLM after the 2.6.0 release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old values will be kept in the modem library for a couple of releases, so there should be no need to map the old values to the new ones.

applications/serial_lte_modem/doc/SOCKET_AT_commands.rst Outdated Show resolved Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_2.6.rst
@@ -19,6 +19,40 @@ The following changes are mandatory to make your application work in the same wa
The setting controls whether the SLM connects automatically to the network on startup.
You can read and write it using the ``AT#XCARRIER="auto_connect"`` command.

* The handling of Release Assistance Indication (RAI) socket options has been updated in the ``#XSOCKETOPT`` command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SLM part should be unnecessary as the old values work as well for now, and we will map those to new values under the hood after 2.6.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old values work as well for now, though the user should update their code to the new values. @divipillai should we add it to the migration guide for the NCS version where we deprecate functionality or the NCS version where we remove the old implementation completely (after it has been deprecated for a while)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we now have a mechanism in place in SLM to keep such values unchanged (we only change the mapping in SLM, so that the customer-facing interface doesn't change), it may well be that they will never change from the SLM user's point of view.
Though if doing this (which I think is what we want, to limit breaking changes) I don't know whether it actually makes sense to introduce the new values in the documentation unless they work somehow differently than the old ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the new values are more well thought out than the previous ones So I would like to have them in SLM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have them then, but also keep the other ones forever (without advertising them)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: The section about RAI in SLM is removed from the migration guide for this release. If the old values are removed at a later point (from SLM user perspective), it should be added to the migration guide then.

trantanen
trantanen reviewed Feb 26, 2024
View reviewed changes
tests/lib/sms/src/sms_test.c
__cmock_nrf_modem_at_cmd_IgnoreArg_len();
__cmock_nrf_modem_at_cmd_ReturnArrayThruPtr_buf(cnmi_reg_nok, sizeof(cnmi_reg_nok));

__mock_nrf_modem_at_printf_ExpectAndReturn("AT+CNMI=3,2,0,1", 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to play with this test to see how it affects on the test coverage and what's the point of the test in the modified form.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eivindj-nordic eivindj-nordic force-pushed the libmodem-v2.6.0 branch 2 times, most recently from 7f8e33b to db7568c Compare February 26, 2024 11:30
@lemrey @eivindj-nordic
manifest: nrf_modem v2.6.0
af823c6 
Pull in latest nrf_modem.
For a detailed list of changes, see its CHANGELOG file.

Signed-off-by: Emanuele Di Santo <[email protected]>
@eivindj-nordic eivindj-nordic mentioned this pull request Feb 26, 2024
Merged
@eivindj-nordic
Copy link
Contributor

eivindj-nordic commented Feb 26, 2024 •
edited
Loading

We have opened #14195 as there is a need to combine the modem library release with the carrier library release. Please direct comments and approvals here.

@lemrey lemrey deleted the libmodem-v2.6.0 branch June 14, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi-font tomi-font tomi-font left review comments

@MarkusLassila MarkusLassila MarkusLassila left review comments

@divipillai divipillai divipillai left review comments

@trantanen trantanen trantanen left review comments

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@tokangas tokangas tokangas approved these changes

@MirkoCovizzi MirkoCovizzi Awaiting requested review from MirkoCovizzi

@eivindj-nordic eivindj-nordic Awaiting requested review from eivindj-nordic

@anhmolt anhmolt Awaiting requested review from anhmolt

@rlubos rlubos Awaiting requested review from rlubos

@juhaylinen juhaylinen Awaiting requested review from juhaylinen

@jhirsi jhirsi Awaiting requested review from jhirsi jhirsi is a code owner

@anangl anangl Awaiting requested review from anangl

@greg-fer greg-fer Awaiting requested review from greg-fer

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

@stig-bjorlykke stig-bjorlykke Awaiting requested review from stig-bjorlykke

Assignees
No one assigned
Labels
DNM doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib manifest-zephyr
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
9 participants
@lemrey @NordicBuilder @eivindj-nordic @tokangas @SeppoTakalo @trantanen @divipillai @MarkusLassila @tomi-font