nrf_modem: release v2.6.0 #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemrey
requested review from
tokangas,
MirkoCovizzi,
eivindj-nordic,
anhmolt and
divipillai
github-actions
bot
added
the
doc-required
lemrey
force-pushed
the
libmodem-v2.6.0
branch
from
ef0885f to
3fa3ea4
Compare
tokangas
reviewed
Feb 26, 2024
eivindj-nordic
force-pushed
the
libmodem-v2.6.0
branch
2 times, most recently
from
4a9570f to
37207ce
Compare
|
@lemrey Please get some +1 asap. |
|
@nrfconnect/ncs-doc-owners Please take a look. |
I am reviewing the PR. |
eivindj-nordic
force-pushed
the
libmodem-v2.6.0
branch
from
37207ce to
4e5a43d
Compare
SeppoTakalo
approved these changes
Feb 26, 2024
tokangas
approved these changes
Feb 26, 2024
|
@nrfconnect/ncs-doc-owners okay to merge it? |
No, tests are failing in nrfconnect/sdk-nrf#14173 |
eivindj-nordic
force-pushed
the
libmodem-v2.6.0
branch
from
391fbf3 to
5b85d30
Compare
eivindj-nordic
force-pushed
the
libmodem-v2.6.0
branch
from
5b85d30 to
4155c17
Compare
MirkoCovizzi
approved these changes
Feb 26, 2024
divipillai
approved these changes
Feb 26, 2024
trantanen
approved these changes
Feb 27, 2024
| /* The function shall allocate and initialize a semaphore and return its address | ||
| through the `sem` parameter. If an address of an already allocated semaphore is provided as | ||
| an input, the allocation part is skipped and the semaphore is only reinitialized. */ | ||
| /* If multithreaded access to modem functionalities is needed, the function must allocate |
There was a problem hiding this comment.
Suggested change
| /* If multithreaded access to modem functionalities is needed, the function must allocate | |
| /* If multithreaded access to modem functionalities is needed, the function must allocate |
eivindj-nordic
force-pushed
the
libmodem-v2.6.0
branch
3 times, most recently
from
afd345a to
d327d0c
Compare
This was referenced Feb 27, 2024
eivindj-nordic
force-pushed
the
libmodem-v2.6.0
branch
from
985eb90 to
cdd774d
Compare
|
@eivindj-nordic ready? |
No, waiting for carrier lib to be ready in nrfconnect/sdk-nrf#14195. |
Add details about NRF_AF_UNSPEC to getaddrinfo docs. Signed-off-by: Eivind Jølsgard <[email protected]>
For a detailed list of changes, see the CHANGELOG file. Co-authored-by: divya pillai <[email protected]> Co-authored-by: Andreas Moltumyr <[email protected]> Co-authored-by: Eivind Jølsgard <[email protected]> Co-authored-by: Mirko Covizzi <[email protected]> Co-authored-by: Tommi Kangas <[email protected]> Signed-off-by: Emanuele Di Santo <[email protected]>
Semaphores are required also for non-multithreaded access. Remove the statement that "Semaphores are not required if multithreaded access to modem functionality is not needed. In this case, the function can blindly return 0." Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
libmodem-v2.6.0
branch
from
cdd774d to
9b19eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a detailed list of changes, see the CHANGELOG file.
sdk-nrf PR: nrfconnect/sdk-nrf#14173