-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1889 neuroendocrine cell #2235
base: master
Are you sure you want to change the base?
Conversation
Fixes #1889 neuroendocrine cell
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsadrenal cortex chromaffin cell
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationschromaffin cell of adrenal gland
|
… neurecto-epithelial cell'
#gogoeditdiff |
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Hi @dosumis, I think all discussed edits have been implemented. Cheers! |
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so. |
#gogoeditdiff |
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so. |
@dosumis: Given that it has been a long time since the last discussion on #1889, is the fix proposed here (which is basically to define |
#gogoeditdiff Note - we will ask for feedback on this issue from the Gut Cell Atlas team - who will be reviewing EC cells, a number of which are sometimes classified as neuro-endocrine. |
This is also a cell type defined in the lung atlas and so we should make sure that the definition is consistent with this location as well. |
Fixes #1889 neuroendocrine cell