Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint #2685

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix lint #2685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
* text=auto
*.sh text eol=lf
*.sh text eol=lf
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ down:

teardown:
docker compose -f docker-compose.yaml -f $(docker_config_file) down -v

load-dummy-data:
docker compose exec backend bash -c "python manage.py load_dummy_data"
Comment on lines 34 to 35
Copy link

@coderabbitai coderabbitai bot Dec 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

The new target should be marked as .PHONY

I couldn't help but notice that this target isn't marked as .PHONY like its siblings. We wouldn't want it feeling left out, would we?

Add the target to the .PHONY declaration at the top:

-.PHONY: logs
+.PHONY: logs load-dummy-data

Committable suggestion skipped: line range outside the PR's diff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh really, can you explain why that target needs to be marked as .PHONY

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainak Typically, a Make target is marked as .PHONY when it doesn’t correspond to a real file—this tells Make it should always run that target’s commands. If there happened to be a file named load-dummy-data in the project folder, Make might see it as “already up to date” and skip the recipe. Declaring it as .PHONY prevents that confusion and guarantees the target always does its job.


Expand Down
Loading