Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Use Inferencer to implement Demo #2763

Merged
merged 11 commits into from
Oct 18, 2023

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

demo/mono_det_demo.py Outdated Show resolved Hide resolved
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the default visualization option to False, because users may have trouble installing open3d on clusters but they need test the inference demo.

By the way, update the doc if necessary.

demo/mono_det_demo.py Outdated Show resolved Hide resolved
demo/multi_modality_demo.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 260 lines in your changes are missing coverage. Please review.

Files Coverage Δ
mmdet3d/__init__.py 100.00% <100.00%> (ø)
mmdet3d/datasets/transforms/formating.py 58.33% <ø> (ø)
mmdet3d/datasets/transforms/transforms_3d.py 40.09% <100.00%> (+0.11%) ⬆️
mmdet3d/models/necks/second_fpn.py 90.62% <ø> (ø)
mmdet3d/version.py 61.53% <100.00%> (ø)
mmdet3d/apis/inference.py 12.97% <0.00%> (ø)
mmdet3d/engine/hooks/visualization_hook.py 50.98% <71.42%> (+1.50%) ⬆️
mmdet3d/datasets/transforms/loading.py 45.75% <42.85%> (+0.84%) ⬆️
mmdet3d/apis/inferencers/mono_det3d_inferencer.py 79.41% <70.58%> (-10.42%) ⬇️
mmdet3d/apis/inferencers/lidar_seg3d_inferencer.py 45.00% <10.52%> (-10.72%) ⬇️
... and 4 more

... and 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@Tai-Wang Tai-Wang merged commit db39fd4 into open-mmlab:dev-1.x Oct 18, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants