[repo] Bump SDK to 9.0.100 #2316

xiang17 · 2024-11-12T18:54:46Z

Towards #2319.

Changes

Added .NET 9 SDK in CI for building projects while minimizing changes: target frameworks are not updated for any projects except for AOT compatibility test. Individual component owners can add support for .NET 9 SDK at their own pace.
Added support for .NET 9 in AOT compatibility test.
Updated docker compose to run integration tests for Kafka and StackExchangeRedis to build with .NET 9 SDK in Docker.
Set AnalysisLevel to 8.0 to minimize changes in this PR.

Merge requirement checklist

CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
~~[ ] Unit tests added/updated~~
~~[ ] Appropriate CHANGELOG.md files updated for non-trivial changes~~: components are not upgraded. Only building with new SDK version.
~~[ ] Changes in public API reviewed (if applicable)~~

codecov · 2024-11-12T18:57:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.04%. Comparing base (71655ce) to head (a283531).
Report is 593 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
- Coverage   73.91%   72.04%   -1.88%     
==========================================
  Files         267      359      +92     
  Lines        9615    13771    +4156     
==========================================
+ Hits         7107     9921    +2814     
- Misses       2508     3850    +1342

see 379 files with indirect coverage changes

xiang17 · 2024-11-12T19:00:32Z

build/Common.props

@@ -10,7 +10,7 @@
    <NetMinimumSupportedVersion>net8.0</NetMinimumSupportedVersion>
    <NetStandardMinimumSupportedVersion>netstandard2.0</NetStandardMinimumSupportedVersion>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <AnalysisLevel>latest-all</AnalysisLevel>
+    <AnalysisLevel>8.0</AnalysisLevel>


If I don't set the AnalysisLevel to 8.0, there will be tons of syntax suggestions showing as errors and failing build: #2313.

…ore.App.Ref with version (= 8.0.11)`. However 8.0.11 was released less than 20 min ago. Maybe the restore step had a delay and didn't get the new version yet? D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (= 8.0.11) D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102: - Found 128 version(s) in NuGet [ Nearest version: 9.0.0-preview.1.24081.5 ] D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102: - Found 0 version(s) in C:\Program Files\dotnet\library-packs Failed to restore D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj (in 20.62 sec).

…uild-test-exporter-geneva-integration / build-test (ubuntu-24.04, net8.0) runs on Ubuntu 22.04.1 LTS. If not set, the version is newer. For example, build-test-exporter-influxdb / build-test (ubuntu-latest, net8.0) runs on Ubuntu 22.04.5 LTS.

…T SDK in a docker.

…ult yet

.github/workflows/ci.yml

build/docker-compose.net8.0.yml

…fail in GitHub CI for now, both for confluentkafka-integration and stackexchangeredis-integration. The current latest SDK in mcr.microsoft.com/dotnet/sdk:9.0 is 9.0.100-rc.2.24474.11, as shown in CI. I'll revert global.json to use rc.2 for now.

…ow to be inspected later.

xiang17 · 2024-11-12T20:34:15Z

test/OpenTelemetry.Exporter.Geneva.Tests/UnixUserEventsDataTransportTests.cs

@@ -50,8 +50,8 @@ public UnixUserEventsDataTransportTests(ITestOutputHelper testOutputHelper)
        this.testOutputHelper = testOutputHelper;
    }

-    [SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true)]
-    public void UserEvents_Enabled_Succes_Linux()
+    [Fact(Skip = "This would fail on Ubuntu. Skipping for now.")]


These two tests are failing (only on Ubuntu) after upgrading to .NET 9. Disabling them for now to be inspected later.

Consider creating separate issue and link them in the code.

Created #2326.

… stable version now. docker run --rm mcr.microsoft.com/dotnet/sdk:9.0 dotnet --info .NET SDK: Version: 9.0.100 Commit: 59db016f11 Workload version: 9.0.100-manifests.3068a692 MSBuild version: 17.12.7+5b8665660 The image info is: `Digest: sha256:7d24e90a392e88eb56093e4eb325ff883ad609382a55d42f17fd557b997022ca`. Earlier today, the version was rc.2: docker run --rm mcr.microsoft.com/dotnet/sdk:9.0@sha256:c6a6d7995042bc8905825c2f1e2f8717733e90738a09fb0d30f917596f4bcb10 dotnet --info .NET SDK: Version: 9.0.100-rc.2.24474.11 Commit: 315e1305db Workload version: 9.0.100-manifests.cea95dba MSBuild version: 17.12.0-preview-24473-03+fea15fbd1

Kielek · 2024-11-13T03:17:13Z

test/OpenTelemetry.Exporter.Geneva.Tests/UnixUserEventsDataTransportTests.cs

@@ -50,8 +50,8 @@ public UnixUserEventsDataTransportTests(ITestOutputHelper testOutputHelper)
        this.testOutputHelper = testOutputHelper;
    }

-    [SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true)]
-    public void UserEvents_Enabled_Succes_Linux()
+    [Fact(Skip = "This would fail on Ubuntu. Skipping for now.")]


Consider creating separate issue and link them in the code.

Kielek · 2024-11-13T03:20:51Z

.github/workflows/ci.yml

@@ -104,8 +104,6 @@ jobs:
    with:
      project-name: Component[OpenTelemetry.Exporter.Geneva]
      code-cov-name: Exporter.Geneva
-      os-list: '[ "ubuntu-24.04" ]' # Note: This may be switched to latest once ubuntu-latest has a kernel version >= 6.8.0-1014-azure
-      tfm-list: '[ "net8.0" ]' # Note: Should be able to remove this once the above is using ubuntu-latest


There is couple other occurrences of tfm-list which should be updated in this file (extended by net9.0)

I don't think we need to do that until projects actually have net9.0 targets added.

.github/workflows/verifyaotcompat.yml

CodeBlanch

LGTM

Build projects with .NET 9 SDK

1c3ced6

xiang17 had a problem deploying to external November 12, 2024 18:54 — with GitHub Actions Failure

github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Nov 12, 2024

xiang17 commented Nov 12, 2024

View reviewed changes

xiang17 had a problem deploying to external November 12, 2024 19:20 — with GitHub Actions Failure

xiang17 had a problem deploying to external November 12, 2024 19:36 — with GitHub Actions Failure

xiang17 added 2 commits November 12, 2024 11:50

Upgrade Kafka and StackExchangeRedis integration tests which uses .NE…

ba5056f

…T SDK in a docker.

Update .NET SDK version for AOT Compatibility Test

5d7f503

xiang17 had a problem deploying to external November 12, 2024 19:50 — with GitHub Actions Failure

github-actions bot requested review from g7ed6e and matt-hensley November 12, 2024 19:50

github-actions bot added comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis labels Nov 12, 2024

xiang17 added 2 commits November 12, 2024 12:04

Install .NET 9 for AOT tests. The .NET SDK 9 is not installed by defa…

e034be3

…ult yet

Update docker invokation in CI to have both .NET 8 and 9

30341a1

xiang17 had a problem deploying to external November 12, 2024 20:06 — with GitHub Actions Failure

xiang17 commented Nov 12, 2024

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

xiang17 commented Nov 12, 2024

View reviewed changes

build/docker-compose.net8.0.yml Show resolved Hide resolved

xiang17 added 2 commits November 12, 2024 12:30

The tests are failing after upgrading to .NET 9. Disabling them for n…

cf4cef8

…ow to be inspected later.

xiang17 had a problem deploying to external November 12, 2024 20:33 — with GitHub Actions Failure

github-actions bot requested review from cijothomas, CodeBlanch, rajkumar-rangaraj and utpilla November 12, 2024 20:33

github-actions bot added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Nov 12, 2024

xiang17 commented Nov 12, 2024

View reviewed changes

xiang17 requested a deployment to external November 12, 2024 23:39 — with GitHub Actions Waiting

xiang17 mentioned this pull request Nov 13, 2024

[feature request] Add support for .NET 9 #2319

Closed

xiang17 marked this pull request as ready for review November 13, 2024 00:52

xiang17 requested a review from a team as a code owner November 13, 2024 00:52

xiang17 mentioned this pull request Nov 13, 2024

Add .NET 9 in tests projects #2313

Merged

2 tasks

xiang17 had a problem deploying to external November 13, 2024 02:11 — with GitHub Actions Failure

github-actions bot assigned cijothomas, CodeBlanch, g7ed6e, matt-hensley, rajkumar-rangaraj and utpilla Nov 13, 2024

Kielek approved these changes Nov 13, 2024

View reviewed changes

Kielek self-requested a review November 13, 2024 03:21

CodeBlanch changed the title ~~Build projects with .NET 9 SDK~~ [repo] Bump SDK to 9.0.100 Nov 13, 2024

Merge branch 'main' into xiang17/dotnet9CIExperiment

3471b3e

CodeBlanch had a problem deploying to external November 13, 2024 06:18 — with GitHub Actions Failure

Tweak.

eadc102

CodeBlanch had a problem deploying to external November 13, 2024 06:22 — with GitHub Actions Failure

CodeBlanch reviewed Nov 13, 2024

View reviewed changes

.github/workflows/verifyaotcompat.yml Outdated Show resolved Hide resolved

Update .github/workflows/verifyaotcompat.yml

a283531

CodeBlanch temporarily deployed to external November 13, 2024 06:26 — with GitHub Actions Inactive

github-actions bot requested a review from CodeBlanch November 13, 2024 06:26

CodeBlanch approved these changes Nov 13, 2024

View reviewed changes

rajkumar-rangaraj approved these changes Nov 13, 2024

View reviewed changes

Kielek approved these changes Nov 13, 2024

View reviewed changes

Kielek merged commit b2c20e3 into open-telemetry:main Nov 13, 2024
136 checks passed

xiang17 mentioned this pull request Nov 15, 2024

[Exporter.Geneva] Fix user event unit tests failures on .NET 9 #2326

Open

xiang17 deleted the xiang17/dotnet9CIExperiment branch December 5, 2024 23:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[repo] Bump SDK to 9.0.100 #2316

[repo] Bump SDK to 9.0.100 #2316

xiang17 commented Nov 12, 2024 •

edited

Loading

codecov bot commented Nov 12, 2024 •

edited

Loading

xiang17 Nov 12, 2024

xiang17 Nov 12, 2024

Kielek Nov 13, 2024

xiang17 Nov 15, 2024

Kielek Nov 13, 2024

Kielek Nov 13, 2024

CodeBlanch Nov 13, 2024

CodeBlanch left a comment

[repo] Bump SDK to 9.0.100 #2316

[repo] Bump SDK to 9.0.100 #2316

Conversation

xiang17 commented Nov 12, 2024 • edited Loading

Changes

Merge requirement checklist

codecov bot commented Nov 12, 2024 • edited Loading

Codecov Report

xiang17 Nov 12, 2024

Choose a reason for hiding this comment

xiang17 Nov 12, 2024

Choose a reason for hiding this comment

Kielek Nov 13, 2024

Choose a reason for hiding this comment

xiang17 Nov 15, 2024

Choose a reason for hiding this comment

Kielek Nov 13, 2024

Choose a reason for hiding this comment

Kielek Nov 13, 2024

Choose a reason for hiding this comment

CodeBlanch Nov 13, 2024

Choose a reason for hiding this comment

CodeBlanch left a comment

Choose a reason for hiding this comment

xiang17 commented Nov 12, 2024 •

edited

Loading

codecov bot commented Nov 12, 2024 •

edited

Loading