Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Bump SDK to 9.0.100 #2316

Merged
merged 17 commits into from
Nov 13, 2024
Merged

[repo] Bump SDK to 9.0.100 #2316

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1c3ced6
Build projects with .NET 9 SDK
xiang17 Nov 12, 2024
927b18a
The last CI run failed with `Unable to find package Microsoft.AspNetC…
xiang17 Nov 12, 2024
ca18ad3
ubuntu-latest is pointing to a newer version than ubuntu-24.04 now. b…
xiang17 Nov 12, 2024
ba5056f
Upgrade Kafka and StackExchangeRedis integration tests which uses .NE…
xiang17 Nov 12, 2024
5d7f503
Update .NET SDK version for AOT Compatibility Test
xiang17 Nov 12, 2024
e034be3
Install .NET 9 for AOT tests. The .NET SDK 9 is not installed by defa…
xiang17 Nov 12, 2024
30341a1
Update docker invokation in CI to have both .NET 8 and 9
xiang17 Nov 12, 2024
c723ee1
In docker-compose.net8.0.yml, setting BUILD_SDK_VERSION to 9.0 would …
xiang17 Nov 12, 2024
cf4cef8
The tests are failing after upgrading to .NET 9. Disabling them for n…
xiang17 Nov 12, 2024
c875d77
remove unused using statement
xiang17 Nov 12, 2024
3c7638e
Removing .net 9 docker tests because the kafka and StackExchangeRedis…
xiang17 Nov 12, 2024
de143fa
Amend last commit: update CI to not invoke .NET 9 for docker integ tests
xiang17 Nov 12, 2024
0f36251
Add .NET 9 in target framework for AOT compatibility test
xiang17 Nov 12, 2024
1c05645
update global.json because dotnet docker image is updated with .NET 9…
xiang17 Nov 13, 2024
3471b3e
Merge branch 'main' into xiang17/dotnet9CIExperiment
CodeBlanch Nov 13, 2024
eadc102
Tweak.
CodeBlanch Nov 13, 2024
a283531
Update .github/workflows/verifyaotcompat.yml
CodeBlanch Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ jobs:
with:
project-name: Component[OpenTelemetry.Exporter.Geneva]
code-cov-name: Exporter.Geneva
os-list: '[ "ubuntu-24.04" ]' # Note: This may be switched to latest once ubuntu-latest has a kernel version >= 6.8.0-1014-azure
tfm-list: '[ "net8.0" ]' # Note: Should be able to remove this once the above is using ubuntu-latest
xiang17 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is couple other occurrences of tfm-list which should be updated in this file (extended by net9.0)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to do that until projects actually have net9.0 targets added.

test-case-filter: CategoryName=Geneva:user_events:metrics
test-require-elevated: true
pack: false
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/verifyaotcompat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,15 @@ jobs:
fail-fast: false # ensures the entire test matrix is run, even if one permutation fails
matrix:
os: [ ubuntu-latest, windows-latest ]
version: [ net8.0 ]
version: [ net8.0, net9.0 ]

runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4

- name: Setup dotnet # The runner does not have .NET 9 SDK installed by default yet.
CodeBlanch marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/setup-dotnet@v4

- name: publish AOT testApp, assert static analysis warning count, and run the app
shell: pwsh
run: .\build\scripts\test-aot-compatibility.ps1 ${{ matrix.version }}
1 change: 1 addition & 0 deletions build/Common.nonprod.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<MicrosoftNETTestSdkPkgVer>[17.11.1,18.0)</MicrosoftNETTestSdkPkgVer>
<OpenTelemetryExporterInMemoryPkgVer>$(OpenTelemetryCoreLatestVersion)</OpenTelemetryExporterInMemoryPkgVer>
<SupportedNetTargets>net8.0</SupportedNetTargets>
<TargetFrameworksForAotCompatibilityTests>net9.0;net8.0</TargetFrameworksForAotCompatibilityTests>
<XUnitRunnerVisualStudioPkgVer>[2.8.2,3.0)</XUnitRunnerVisualStudioPkgVer>
<XUnitPkgVer>[2.9.0,3.0)</XUnitPkgVer>
<WiremockNetPkgVer>[1.6.3,2.0)</WiremockNetPkgVer>
Expand Down
2 changes: 1 addition & 1 deletion build/Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<NetMinimumSupportedVersion>net8.0</NetMinimumSupportedVersion>
<NetStandardMinimumSupportedVersion>netstandard2.0</NetStandardMinimumSupportedVersion>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<AnalysisLevel>latest-all</AnalysisLevel>
<AnalysisLevel>8.0</AnalysisLevel>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't set the AnalysisLevel to 8.0, there will be tons of syntax suggestions showing as errors and failing build: #2313.

<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<NuGetAudit>true</NuGetAudit>
Expand Down
2 changes: 1 addition & 1 deletion build/docker-compose.net8.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ services:
args:
PUBLISH_FRAMEWORK: net8.0
TEST_SDK_VERSION: "8.0"
BUILD_SDK_VERSION: "8.0"
BUILD_SDK_VERSION: "9.0"
xiang17 marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion build/scripts/test-aot-compatibility.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ param([string]$targetNetFramework)

$rootDirectory = Get-Location

$publishOutput = dotnet publish $rootDirectory/test/OpenTelemetry.AotCompatibility.TestApp/OpenTelemetry.AotCompatibility.TestApp.csproj -nodeReuse:false /p:UseSharedCompilation=false
$publishOutput = dotnet publish $rootDirectory/test/OpenTelemetry.AotCompatibility.TestApp/OpenTelemetry.AotCompatibility.TestApp.csproj --framework $targetNetFramework -nodeReuse:false /p:UseSharedCompilation=false

$actualWarningCount = 0

Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"rollForward": "latestFeature",
"version": "8.0.100"
"version": "9.0.100"
}
}
2 changes: 1 addition & 1 deletion test/OpenTelemetry.AotCompatibility.TestApp/OpenTelemetry.AotCompatibility.TestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>$(NetMinimumSupportedVersion)</TargetFramework>
<TargetFrameworks>$(TargetFrameworksForAotCompatibilityTests)</TargetFrameworks>
<PublishAot>true</PublishAot>
<TrimmerSingleWarn>false</TrimmerSingleWarn>
<EventSourceSupport>true</EventSourceSupport>
Expand Down
9 changes: 4 additions & 5 deletions test/OpenTelemetry.Exporter.Geneva.Tests/UnixUserEventsDataTransportTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using System.Globalization;
using System.Text.RegularExpressions;
using Microsoft.LinuxTracepoints.Provider;
using OpenTelemetry.Tests;
using Xunit;
using Xunit.Abstractions;

Expand Down Expand Up @@ -50,8 +49,8 @@ public UnixUserEventsDataTransportTests(ITestOutputHelper testOutputHelper)
this.testOutputHelper = testOutputHelper;
}

[SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true)]
public void UserEvents_Enabled_Succes_Linux()
[Fact(Skip = "This would fail on Ubuntu. Skipping for now.")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two tests are failing (only on Ubuntu) after upgrading to .NET 9. Disabling them for now to be inspected later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider creating separate issue and link them in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #2326.

public void UserEvents_Enabled_Success_Linux()
{
EnsureUserEventsEnabled();

Expand Down Expand Up @@ -114,8 +113,8 @@ public void UserEvents_Enabled_Succes_Linux()
}
}

[SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true)]
public void UserEvents_Disabled_Succes_Linux()
[Fact(Skip = "This would fail on Ubuntu. Skipping for now.")]
public void UserEvents_Disabled_Success_Linux()
{
EnsureUserEventsEnabled();

Expand Down
6 changes: 3 additions & 3 deletions test/OpenTelemetry.Instrumentation.ConfluentKafka.Tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
# This should be run from the root of the repo:
# docker build --file test/OpenTelemetry.Instrumentation.ConfluentKafka.Tests/Dockerfile .

ARG BUILD_SDK_VERSION=8.0
ARG TEST_SDK_VERSION=8.0
ARG BUILD_SDK_VERSION=9.0
ARG TEST_SDK_VERSION=9.0

FROM mcr.microsoft.com/dotnet/sdk:${BUILD_SDK_VERSION} AS build
ARG PUBLISH_CONFIGURATION=Release
ARG PUBLISH_FRAMEWORK=net8.0
ARG PUBLISH_FRAMEWORK=net9.0
WORKDIR /repo
COPY . ./
WORKDIR "/repo/test/OpenTelemetry.Instrumentation.ConfluentKafka.Tests"
Expand Down
6 changes: 3 additions & 3 deletions test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
# This should be run from the root of the repo:
# docker build --file test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests/Dockerfile .

ARG BUILD_SDK_VERSION=8.0
ARG TEST_SDK_VERSION=8.0
ARG BUILD_SDK_VERSION=9.0
ARG TEST_SDK_VERSION=9.0

FROM mcr.microsoft.com/dotnet/sdk:${BUILD_SDK_VERSION} AS build
ARG PUBLISH_CONFIGURATION=Release
ARG PUBLISH_FRAMEWORK=net8.0
ARG PUBLISH_FRAMEWORK=net9.0
WORKDIR /repo
COPY . ./
WORKDIR "/repo/test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests"
Expand Down
Loading