-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Semantic Convention handling in AWS libraries. #2367
Upgrade Semantic Convention handling in AWS libraries. #2367
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
- Coverage 73.91% 0 -73.92%
==========================================
Files 267 0 -267
Lines 9615 0 -9615
==========================================
- Hits 7107 0 -7107
+ Misses 2508 0 -2508 |
da63599
to
3183104
Compare
3183104
to
ddef75b
Compare
ddef75b
to
f62eb8d
Compare
f62eb8d
to
59b59f1
Compare
59b59f1
to
ed49ef0
Compare
src/OpenTelemetry.Instrumentation.AWSLambda/OpenTelemetry.Instrumentation.AWSLambda.csproj
Outdated
Show resolved
Hide resolved
ed49ef0
to
1dbdb19
Compare
Co-authored-by: Alan West <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Semantinc Convention enums
…e reference to that project
…imental status in documentation
2b9780c
to
6c1f07a
Compare
6c1f07a
to
7118581
Compare
7118581
to
6164f19
Compare
6164f19
to
7f11f07
Compare
7f11f07
to
970d286
Compare
…n semantic convention output). There will be a fast follow PR to remove Legacy in preparation for an RC.
970d286
to
d70a0c5
Compare
Co-authored-by: Alan West <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this PR at length with @ppittle today.
The plan is to release one more beta version of these instrumentations that supports the existing conventions they emit. By default the telemetry they emits does not change with this PR, but a user can now opt in to specific versions of the semantic conventions.
A release candidate will ship shortly after the last beta version. The release candidate will default to the new semantic conventions and remove support for the "legacy" conventions.
There are some active reviewers of this PR that have not had a opportunity to approve it yet (@Oberon00 and @Kielek). Since this PR should not be changing any behavior by default, I've decided to approve and merge it so that we can release the next beta version. @ppittle will open up the follow up PR in preparation of the release candidate soon. That should give folks the chance to weigh in with any additional feedback on this plan.
Fixes #
Design discussion issue #
NOTE: This PR is built on top of #2363, #2363 should be merged first.
Updates 2
This PR will contain -no- change in Semantic Convention by default. Users can opt-in to
SemanticConventionVersions.1.28
, but default isSemanticConventionVersions.Legacy
.Once merged, this PR will be released as a beta - allowing users a non-breaking way to test opting in-to 1.28.
There will be a fast follow up PR that removes
SemanticConventionVersions.Legacy
and changes the default toSemanticConventionVersions.V1_28_0
. That PR will be merged and released as a Release Candidate.This follows the release strategy for other contrib packages that have made similar breaking changes around Semantic Convention stabilization.
Updates 1
SemanticConventionVersions
track the version of the OpenTelemetry.*.AWS Libraries has been scrapped in favor of tracking Semantic Convnetion repo release versions.Semantic Convention 1.28.
AWSSemanticConvention.DefaultSemanticConventionVersion
Changes
Implementation of the design discussed in the Nov 26th OpenTelemetry .NET SIG meeting. This design allows releasing the AWS OTel Contrib libraries as GA while still informing users that underlying Semantic Conventions are experimental.
This is exposed via the
SemanticConventionVersion
enum:Users can choose how to handle this for their applications by either pinning to a specific Semantic Convention version or automatically getting updates the next time they upgrade the AWS Otel nuget packages.
Selection is made by updating the Options object in the builder method.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes