Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] fix geneva integration test #2408

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Dec 10, 2024

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

xiang17 and others added 18 commits November 12, 2024 10:53
…ore.App.Ref with version (= 8.0.11)`. However 8.0.11 was released less than 20 min ago. Maybe the restore step had a delay and didn't get the new version yet?

D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (= 8.0.11)
D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102:   - Found 128 version(s) in NuGet [ Nearest version: 9.0.0-preview.1.24081.5 ]
D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102:   - Found 0 version(s) in C:\Program Files\dotnet\library-packs
  Failed to restore D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj (in 20.62 sec).
…uild-test-exporter-geneva-integration / build-test (ubuntu-24.04, net8.0) runs on Ubuntu 22.04.1 LTS. If not set, the version is newer. For example, build-test-exporter-influxdb / build-test (ubuntu-latest, net8.0) runs on Ubuntu 22.04.5 LTS.
…fail in GitHub CI for now, both for confluentkafka-integration and stackexchangeredis-integration. The current latest SDK in mcr.microsoft.com/dotnet/sdk:9.0 is 9.0.100-rc.2.24474.11, as shown in CI.

I'll revert global.json to use rc.2 for now.
… doesn't have net9.0 targets yet. I'll leave to the component owners to upgrade them.
… stable version now.

docker run --rm mcr.microsoft.com/dotnet/sdk:9.0 dotnet --info
.NET SDK:
 Version:           9.0.100
 Commit:            59db016f11
 Workload version:  9.0.100-manifests.3068a692
 MSBuild version:   17.12.7+5b8665660

The image info is: `Digest: sha256:7d24e90a392e88eb56093e4eb325ff883ad609382a55d42f17fd557b997022ca`.

Earlier today, the version was rc.2:

 docker run --rm mcr.microsoft.com/dotnet/sdk:9.0@sha256:c6a6d7995042bc8905825c2f1e2f8717733e90738a09fb0d30f917596f4bcb10 dotnet --info
.NET SDK:
 Version:           9.0.100-rc.2.24474.11
 Commit:            315e1305db
 Workload version:  9.0.100-manifests.cea95dba
 MSBuild version:   17.12.0-preview-24473-03+fea15fbd1
@xiang17 xiang17 changed the title Xiang17/dotnet9 ci experiment fix geneva integration test [draft] fix geneva integration test Dec 10, 2024
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis labels Dec 10, 2024
@github-actions github-actions bot removed comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.43%. Comparing base (71655ce) to head (f3c0cc1).
Report is 644 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2408      +/-   ##
==========================================
- Coverage   73.91%   72.43%   -1.48%     
==========================================
  Files         267      370     +103     
  Lines        9615    13715    +4100     
==========================================
+ Hits         7107     9935    +2828     
- Misses       2508     3780    +1272     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 84.04% <ø> (?)
unittests-Exporter.Geneva 57.96% <ø> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.57% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 86.39% <ø> (?)
unittests-Instrumentation.AspNet 77.00% <ø> (?)
unittests-Instrumentation.AspNetCore 70.33% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.37% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcCore 91.42% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 62.18% <ø> (?)
unittests-Instrumentation.Owin 88.12% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.76% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 89.77% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.26% <ø> (?)
unittests-Instrumentation.Wcf 78.57% <ø> (?)
unittests-PersistentStorage 65.21% <ø> (?)
unittests-Resources.AWS 78.57% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 76.98% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 88.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 386 files with indirect coverage changes

@xiang17 xiang17 closed this Dec 11, 2024
@xiang17 xiang17 deleted the xiang17/dotnet9CIExperiment-fix-geneva-integration-test branch December 11, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants