Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] fix geneva integration test #2408

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1c3ced6
Build projects with .NET 9 SDK
xiang17 Nov 12, 2024
927b18a
The last CI run failed with `Unable to find package Microsoft.AspNetC…
xiang17 Nov 12, 2024
ca18ad3
ubuntu-latest is pointing to a newer version than ubuntu-24.04 now. b…
xiang17 Nov 12, 2024
ba5056f
Upgrade Kafka and StackExchangeRedis integration tests which uses .NE…
xiang17 Nov 12, 2024
5d7f503
Update .NET SDK version for AOT Compatibility Test
xiang17 Nov 12, 2024
e034be3
Install .NET 9 for AOT tests. The .NET SDK 9 is not installed by defa…
xiang17 Nov 12, 2024
30341a1
Update docker invokation in CI to have both .NET 8 and 9
xiang17 Nov 12, 2024
c723ee1
In docker-compose.net8.0.yml, setting BUILD_SDK_VERSION to 9.0 would …
xiang17 Nov 12, 2024
cf4cef8
The tests are failing after upgrading to .NET 9. Disabling them for n…
xiang17 Nov 12, 2024
c875d77
remove unused using statement
xiang17 Nov 12, 2024
3c7638e
Removing .net 9 docker tests because the kafka and StackExchangeRedis…
xiang17 Nov 12, 2024
de143fa
Amend last commit: update CI to not invoke .NET 9 for docker integ tests
xiang17 Nov 12, 2024
0f36251
Add .NET 9 in target framework for AOT compatibility test
xiang17 Nov 12, 2024
1c05645
update global.json because dotnet docker image is updated with .NET 9…
xiang17 Nov 13, 2024
3471b3e
Merge branch 'main' into xiang17/dotnet9CIExperiment
CodeBlanch Nov 13, 2024
eadc102
Tweak.
CodeBlanch Nov 13, 2024
a283531
Update .github/workflows/verifyaotcompat.yml
CodeBlanch Nov 13, 2024
a360e2b
Add back OS requirementsfor geneva exporter integration test
xiang17 Dec 10, 2024
551206a
Merge branch 'main' into xiang17/dotnet9CIExperiment-fix-geneva-integ…
xiang17 Dec 11, 2024
6c9672b
add using statement
xiang17 Dec 11, 2024
f3c0cc1
Add back OS requirementsfor geneva exporter integration test
xiang17 Dec 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ jobs:
with:
project-name: Component[OpenTelemetry.Exporter.Geneva]
code-cov-name: Exporter.Geneva
os-list: '[ "ubuntu-24.04" ]' # Note: This may be switched to latest once ubuntu-latest has a kernel version >= 6.8.0-1014-azure
tfm-list: '[ "net8.0" ]' # Note: Should be able to remove this once the above is using ubuntu-latest
test-case-filter: CategoryName=Geneva:user_events:metrics
test-require-elevated: true
pack: false
Expand Down Expand Up @@ -197,7 +199,7 @@ jobs:
with:
project-name: OpenTelemetry.Instrumentation.AspNetCore
code-cov-name: Instrumentation.AspNetCore
tfm-list: '[ "net8.0", "net9.0" ]'
tfm-list: '[ "net8.0" ]'

build-test-instrumentation-aws:
needs: detect-changes
Expand Down Expand Up @@ -279,7 +281,7 @@ jobs:
with:
project-name: OpenTelemetry.Instrumentation.EventCounters
code-cov-name: Instrumentation.EventCounters
tfm-list: '[ "net8.0", "net9.0" ]'
tfm-list: '[ "net8.0" ]'

build-test-instrumentation-grpccore:
needs: detect-changes
Expand Down
2 changes: 1 addition & 1 deletion build/Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<NetMinimumSupportedVersion>net8.0</NetMinimumSupportedVersion>
<NetStandardMinimumSupportedVersion>netstandard2.0</NetStandardMinimumSupportedVersion>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<AnalysisLevel>latest-all</AnalysisLevel>
<AnalysisLevel>8.0</AnalysisLevel>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<NuGetAudit>true</NuGetAudit>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Globalization;
using System.Text.RegularExpressions;
using Microsoft.LinuxTracepoints.Provider;
using OpenTelemetry.Tests;
using Xunit;
using Xunit.Abstractions;

Expand Down Expand Up @@ -49,7 +50,7 @@ public UnixUserEventsDataTransportTests(ITestOutputHelper testOutputHelper)
this.testOutputHelper = testOutputHelper;
}

[Fact(Skip = "This would fail on Ubuntu. Skipping for now.")]
[SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true)]
public void UserEvents_Enabled_Success_Linux()
{
EnsureUserEventsEnabled();
Expand Down Expand Up @@ -113,7 +114,7 @@ public void UserEvents_Enabled_Success_Linux()
}
}

[Fact(Skip = "This would fail on Ubuntu. Skipping for now.")]
[SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true)]
public void UserEvents_Disabled_Success_Linux()
{
EnsureUserEventsEnabled();
Expand Down
Loading