Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark-pull-request.yml Workflow Improvements. #16925

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Dec 31, 2024

Description

benchmark-pull-request.yml Workflow Improvements.

  • Restrict the workflow to opensearch-project/OpenSearch repo.
  • Avoid using substring match with JSON-encoded, ensuring robustness in parsing and processing with an exact match to an element in the array.

Related Issues

NA: Workflow Improvements.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi prudhvigodithi marked this pull request as ready for review January 2, 2025 19:15
@rishabh6788
Copy link
Contributor

Thanks @prudhvigodithi for hardening security of the workflow.
@reta This PR updates the username match from substring match to exact match so that any other user who matches the substring from any of the maintainer's id is not able to bypass the approval step.

@reta reta merged commit 542b551 into opensearch-project:main Jan 2, 2025
47 of 49 checks passed
reta pushed a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants