Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address return consistency #355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Address return consistency #355

wants to merge 1 commit into from

Conversation

sebrandon1
Copy link
Collaborator

I went through the entire codebase and addressed inconsistencies with return statements to make everything the "same".

Now we can expect:

  • All "NewBuilder" funcs to early return if any params are empty.
  • All With... and operation funcs are modified to return a nil pointer to the builder and the error (if return values are applicable).

@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch 4 times, most recently from 33e7b4b to 701df76 Compare April 25, 2024 16:25
@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch 10 times, most recently from 4b15168 to d4a29cd Compare May 2, 2024 13:53
@sebrandon1 sebrandon1 mentioned this pull request May 2, 2024
Merged
@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch 4 times, most recently from 4a38ea2 to b26e659 Compare May 9, 2024 15:13
@klaskosk klaskosk mentioned this pull request May 13, 2024
Merged
@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch 5 times, most recently from 3817184 to 010f891 Compare May 20, 2024 21:32
@klaskosk klaskosk mentioned this pull request Nov 26, 2024
Open
@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch 3 times, most recently from e200e35 to c77bcd1 Compare November 27, 2024 21:57
@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch 2 times, most recently from 0ab3ba9 to 8dfc26e Compare December 16, 2024 16:22
This was referenced Dec 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch from 8dfc26e to 9c0e0b5 Compare December 17, 2024 20:29
This was referenced Dec 17, 2024
Merged
Merged
@sebrandon1
Address return consistency
61057d6 
add argocd applications updates
@sebrandon1 sebrandon1 force-pushed the newbuilder_validation branch from 9c0e0b5 to 61057d6 Compare December 19, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trewest trewest Awaiting requested review from trewest trewest is a code owner

@achuzhoy achuzhoy Awaiting requested review from achuzhoy achuzhoy is a code owner

@kononovn kononovn Awaiting requested review from kononovn kononovn is a code owner

@wabouhamad wabouhamad Awaiting requested review from wabouhamad wabouhamad is a code owner

@cdvultur cdvultur Awaiting requested review from cdvultur cdvultur is a code owner

@klaskosk klaskosk Awaiting requested review from klaskosk klaskosk is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebrandon1