Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to scraperlib v3.4.0 to use VP9 #236

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Upgrade to scraperlib v3.4.0 to use VP9 #236

merged 2 commits into from
Jun 21, 2024

Conversation

benoit74
Copy link
Collaborator

Partial implementation of #235

  • partial because this PR is an update on the v2 branch since v3 is not yet ready
  • this also needs to be backported to main branch as well
  • tests done
    • run again the scraper => all videos are reencoded with VP9 and reuploaded to cache
    • run again the scraper a second time => all videos are downloaded from cache and are encoded with VP9
  • also implement bootstrap v1.0.2 (fixes to code coverage upload)

@benoit74 benoit74 self-assigned this Jun 21, 2024
@benoit74 benoit74 marked this pull request as ready for review June 21, 2024 13:03
@benoit74 benoit74 requested a review from rgaudin June 21, 2024 13:03
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v2@63945cc). Learn more about missing BASE report.

Additional details and impacted files
@@         Coverage Diff          @@
##             v2    #236   +/-   ##
====================================
  Coverage      ?   1.78%           
====================================
  Files         ?      10           
  Lines         ?     954           
  Branches      ?     158           
====================================
  Hits          ?      17           
  Misses        ?     937           
  Partials      ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit ea75138 into v2 Jun 21, 2024
6 checks passed
@benoit74 benoit74 deleted the scraperlib_3_4_0 branch June 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants