multiple passport brokers & passport refresh token #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoraba
commented
Jun 15, 2023
|
|
||
| if(user.getClaim(GA4GH_PASSPORT_SCOPE) != null && providerType.isEmpty()){ | ||
| providerType = Optional.of(ProviderType.PASSPORT); | ||
| } |
There was a problem hiding this comment.
Assigning a generic providerType "PASSPORT" to any passport provider that contains the scope ga4gh_passport_v1
leoraba
commented
Jun 15, 2023
| ProviderType.resolveProviderType( | ||
| authentication.getAuthorizedClientRegistrationId())) | ||
| .providerType(providerType.get()) | ||
| .providerIssuerUri(user.getIssuer().toString()) |
There was a problem hiding this comment.
this is a new field providerIssuerUri to differentiate passport brokers
Ego issue #723
leoraba
changed the title
joneubank
reviewed
Jul 5, 2023
Comment on lines
+95
to
+100
| private String getRefreshToken(OAuth2UserRequest oAuth2UserRequest) { | ||
| val refreshToken = | ||
| (String) | ||
| oAuth2UserRequest.getAdditionalParameters().get(OAuth2ParameterNames.REFRESH_TOKEN); | ||
| return refreshToken; | ||
| } |
There was a problem hiding this comment.
This formatting is hillarious... is this caused by a line width limit?
joneubank
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: