-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple passport brokers & passport refresh token #718
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/main/java/bio/overture/ego/model/dto/PassportRefreshToken.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package bio.overture.ego.model.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonIgnoreProperties; | ||
import lombok.Data; | ||
import lombok.val; | ||
|
||
import java.util.Calendar; | ||
|
||
@Data | ||
@JsonIgnoreProperties(ignoreUnknown = true) | ||
public class PassportRefreshToken { | ||
private String iss; | ||
private String aud; | ||
private Long exp; // in seconds | ||
private String jti; | ||
|
||
public Long getSecondsUntilExpiry() { | ||
val seconds = this.exp - Calendar.getInstance().getTime().getTime() / 1000L; | ||
return seconds > 0 ? seconds : 0; | ||
} | ||
} |
15 changes: 15 additions & 0 deletions
15
src/main/java/bio/overture/ego/model/dto/PassportRefreshTokenResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package bio.overture.ego.model.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonIgnoreProperties; | ||
import lombok.Data; | ||
|
||
@Data | ||
@JsonIgnoreProperties(ignoreUnknown = true) | ||
public class PassportRefreshTokenResponse { | ||
private String access_token; | ||
private String token_type; | ||
private String refresh_token; | ||
private Long expires_in; | ||
private String scope; | ||
private String id_token; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
import org.springframework.security.oauth2.client.oidc.userinfo.OidcUserService; | ||
import org.springframework.security.oauth2.client.userinfo.OAuth2UserRequest; | ||
import org.springframework.security.oauth2.core.OAuth2AuthenticationException; | ||
import org.springframework.security.oauth2.core.endpoint.OAuth2ParameterNames; | ||
import org.springframework.security.oauth2.core.oidc.user.OidcUser; | ||
import org.springframework.security.oauth2.core.user.DefaultOAuth2User; | ||
import org.springframework.security.oauth2.core.user.OAuth2User; | ||
|
@@ -36,9 +37,9 @@ public OidcUser loadUser(OidcUserRequest oAuth2UserRequest) throws OAuth2Authent | |
OidcUser oidcUser = super.loadUser(oAuth2UserRequest); | ||
try { | ||
String provider = oAuth2UserRequest.getClientRegistration().getRegistrationId(); | ||
val idName = ProviderType.getIdAccessor(ProviderType.resolveProviderType(provider)); | ||
if (provider.equalsIgnoreCase(ProviderType.ORCID.toString())) { | ||
val info = getOrcidUserInfo(oidcUser, oAuth2UserRequest); | ||
val idName = ProviderType.getIdAccessor(ProviderType.resolveProviderType(provider)); | ||
return CustomOAuth2User.builder() | ||
.oauth2User(new DefaultOAuth2User(oidcUser.getAuthorities(), info, idName)) | ||
.subjectId(info.get(idName).toString()) | ||
|
@@ -47,13 +48,16 @@ public OidcUser loadUser(OidcUserRequest oAuth2UserRequest) throws OAuth2Authent | |
.givenName(info.getOrDefault(GIVEN_NAME, "").toString()) | ||
.build(); | ||
} | ||
|
||
val refreshToken = getRefreshToken(oAuth2UserRequest); | ||
return CustomOAuth2User.builder() | ||
.oauth2User(oidcUser) | ||
.subjectId(oidcUser.getSubject()) | ||
.email(oidcUser.getEmail()) | ||
.familyName(oidcUser.getFamilyName()) | ||
.givenName(oidcUser.getGivenName()) | ||
.accessToken(oAuth2UserRequest.getAccessToken().getTokenValue()) | ||
.refreshToken(refreshToken) | ||
.build(); | ||
} catch (AuthenticationException ex) { | ||
throw ex; | ||
|
@@ -87,4 +91,11 @@ private RestTemplate getTemplate(OAuth2UserRequest oAuth2UserRequest) { | |
}); | ||
return restTemplate; | ||
} | ||
|
||
private String getRefreshToken(OAuth2UserRequest oAuth2UserRequest) { | ||
val refreshToken = | ||
(String) | ||
oAuth2UserRequest.getAdditionalParameters().get(OAuth2ParameterNames.REFRESH_TOKEN); | ||
return refreshToken; | ||
} | ||
Comment on lines
+95
to
+100
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This formatting is hillarious... is this caused by a line width limit? |
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigning a generic providerType "PASSPORT" to any passport provider that contains the scope
ga4gh_passport_v1