Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for counting Tera Types #1

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Conversation

shrianshChari
Copy link
Collaborator

I am not able to test Tera type counting on Gen 9 (or past gen) logs on account of not being able to convert them into reports.

@shrianshChari shrianshChari marked this pull request as ready for review August 26, 2024 07:04
@scheibo
Copy link
Contributor

scheibo commented Aug 26, 2024

Looks good! Please pretty print the logs (like stats/src/test/testdata/logs/gen9ubers/gen9ubers-11480.log.json) and name them log.1.json .. log.3.json

@scheibo
Copy link
Contributor

scheibo commented Aug 26, 2024

Sorry for the multiple rounds of reviews, I'm still working to remember the codebase. Can you hand edit the new log files to have ratings, eg:

   "p1rating": {"rpr": 1900, "rprd": 50},
   "p2rating": {"rpr": 1750, "rprd": 100},

So that the output with cutoffs have data? The code definitely looks good, just crossing t's and dotting i's. Thanks!

@scheibo scheibo merged commit d63b96b into pkmn:main Aug 26, 2024
1 check passed
@scheibo
Copy link
Contributor

scheibo commented Aug 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants