Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back right-click-for-new-combo and right-click-delete when in compose mode #31148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 16, 2024

Requested too many times to count.

I'm not sure what to do about the code quality of this. It's a bit weird that there's no way to check the current composition tool from a higher level.

Also it was discussed IRL that there should be some kind of hinting that existing notes will be deleted when they are hovered, but I'm not sure how well this will work in normal mapping flows, since it will display even in cases that users aren't intending to delete an object. Still willing to explore this direction though (it's just non-trivial to implement so I haven't yet).

This is almost definitely not going to pass tests, just want to get this out for initial thoughts before I polish things up.

…pose mode

Requested too many times to count.

I'm not sure what to do about the code quality of this. It's a bit weird
that there's no way to check the current composition tool from a higher
level.

Also it was discussed IRL that there should be some kind of hinting that
existing notes will be deleted when they are hovered, but I'm not sure
how well this will work in normal mapping flows, since it will display
even in cases that users aren't intending to delete an object. Still
willing to explore this direction though (it's just non-trivial to
implement so I haven't yet).
@peppy peppy marked this pull request as draft December 16, 2024 07:18
@bdach
Copy link
Collaborator

bdach commented Dec 16, 2024

It's a bit weird that there's no way to check the current composition tool from a higher level.

Maybe it could work by making ComposeBlueprintContainer.CurrentTool a bindable and binding that down to the appropriate SelectionHandlers. Although now that I say that I get a very sudden deja vu that I've said those exact words previously and it didn't work as intended for whatever reason...?

Maybe worth trying. Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants