-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testimonial] Site refactor updates #424
Conversation
🦋 Changeset detectedLatest commit: 4a7e296 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes- --brand-Testimonial-quote-letterSpacing-large: var(--brand-text-letterSpacing-600);
+ --brand-Testimonial-quote-letterSpacing-large: var(--brand-text-letterSpacing-900); - --brand-Testimonial-quote-letterSpacing-default: var(--brand-text-letterSpacing-300);
+ --brand-Testimonial-quote-letterSpacing-default: var(--brand-text-letterSpacing-400); - --brand-Testimonial-quote-fontWeight-default: var(--brand-text-weight-300);
+ --brand-Testimonial-quote-fontWeight-default: var(--brand-heading-weight-600); - --brand-Testimonial-quote-fontSize-default: var(--brand-text-size-300);
+ --brand-Testimonial-quote-fontSize-default: var(--brand-text-size-400); |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I'm aware, but since there's been lot of changes I think we should tackle documentation once everything is settle down. I included Testimonial as part of the "Update the documentation" issue https://github.com/github/primer/issues/2620 |
Co-authored-by: Rez <[email protected]>
Summary
As part of the https://github.com/github/primer/issues/2494, we'll need to apply some additional change requests to the testimonial component to unblock upcoming, flagship marketing pages.
Docs: https://primer-bb88e44c6c-26139705.drafts.github.io/components/Testimonial/react
Storybook: https://primer-bb88e44c6c-26139705.drafts.github.io/storybook/?path=/story/components-testimonial--playground
List of notable changes:
align
prop, tests and documentationWhat should reviewers focus on?
large
andsmall
size variantsalign
examples and props are removedSteps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots:
Small variant
Large variant