Fewer FPs for phpmyadmin panel #11264
Open
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazet
commented
Nov 29, 2024
| @@ -51,13 +51,16 @@ http: | |||
| matchers: | |||
| - type: word | |||
| words: | |||
| - "<title>phpMyAdmin" | |||
| - "pmahomme" | |||
| - '<title>phpMyAdmin' | |||
There was a problem hiding this comment.
this, coupled with condition: or, will trigger a false positive on sites that echo the path in the title (we observe such cases in our constituency)
There was a problem hiding this comment.
Could you please share some FP with us? DM me on Discord. Join our discord server and search for my username ritikchaddha
|
Thanks for your contribution @kazet ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template / PR Information
Some sites echo the path in the title, thus leading to a false positive.
Template Validation
I've validated this template locally?