Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fewer FPs for phpmyadmin panel #11264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −4
Open

Fewer FPs for phpmyadmin panel #11264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38d60d3
Fewer FPs for phpmyadmin panel
kazet Nov 28, 2024
c0f2e38
Update phpmyadmin-panel.yaml
ritikchaddha Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions http/exposed-panels/phpmyadmin-panel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ info:
- title="phpmyadmin"
google-query: intitle:"phpmyadmin"
hunter-query: app.name="phpmyadmin"&&web.body="pma_servername"&&web.body="4.8.4"
tags: panel,phpmyadmin
tags: panel,phpmyadmin,detect

http:
- method: GET
Expand Down Expand Up @@ -51,13 +51,16 @@ http:
matchers:
- type: word
words:
- "<title>phpMyAdmin"
- "pmahomme"
- '<title>phpMyAdmin'
Copy link
Contributor Author

@kazet kazet Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this, coupled with condition: or, will trigger a false positive on sites that echo the path in the title (we observe such cases in our constituency)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share some FP with us? DM me on Discord. Join our discord server and search for my username ritikchaddha

- 'alt="phpMyAdmin'
- 'name="pma_username'
- '/pmahomme/'
condition: or

extractors:
- type: regex
part: body
group: 1
regex:
- 'v=([a-z0-9-._]+)'
# digest: 490a004630440220722f0389c7c04acc81fc50271521330e06cc1892b6d0978221b61b7c8566f79f02202c408aef3764fd5cbb398ab90944e34e4900f42c8c8c2f9b66b837ab4fb3fc50:922c64590222798bb761d5b6d8e72950
# digest: 490a004630440220722f0389c7c04acc81fc50271521330e06cc1892b6d0978221b61b7c8566f79f02202c408aef3764fd5cbb398ab90944e34e4900f42c8c8c2f9b66b837ab4fb3fc50:922c64590222798bb761d5b6d8e72950
Loading