feat(apply): add support for multiple interfaces in get_intf_ip filter #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_intf_ip` filter now supports a comma-separated list of network interfaces. It returns the first IP address found among the specified interfaces. Additionally, the filter is optimized to cache results, preventing repeated network calls and ensuring better performance when used multiple times in a workflow.
ankitrgadiya
force-pushed
the
feat/improve-get-intf-ip
branch
from
33c344d to
bc29232
Compare
|
🤖 Pull Request Artifacts (#12505022131) 🎉 |
pallabpain
reviewed
Dec 27, 2024
| raise Exception(f'interface "{interface}" not found on device "{device_name}"') | ||
|
|
||
| @lru_cache | ||
| def get_device_ip_interfaces(device_name: str) -> Dict[str, List[str]]: |
There was a problem hiding this comment.
thought: Should we move this from this file to device/util.py instead? That will only keep the filters in this file. What do you think?
Comment on lines
+59
to
+62
| FILTERS = { | ||
| "getenv": getenv, | ||
| "get_intf_ip": get_interface_ip, | ||
| } |
There was a problem hiding this comment.
question: Why do this? Why not keep it in filters.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_intf_ipfilter now supports a comma-separated list of network interfaces. It returns the first IP address found among the specified interfaces.Additionally, the filter is optimized to cache results, preventing repeated network calls and ensuring better performance when used multiple times in a workflow.