Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2cli diagnostics tool #328

Draft
wants to merge 26 commits into
base: ros2
Choose a base branch
from
Draft

Conversation

russkel
Copy link

@russkel russkel commented Jan 21, 2024

Adds a ros2 CLI tool:

TODO

  • rename to ros2diagnostics to follow convention
  • as per your suggestion change verbs to list/echo.
  • convert csv to an output format option on echo: ros2 diagnostics echo -f csv > my-csv.csv (unix philosophy)
    • add yaml/json output
  • refactor DiagnosticsParser into a generator with a WaitSet and remove mode
  • add self test verb
  • add tests

Replaces #301

@russkel russkel marked this pull request as draft January 21, 2024 06:12
@ct2034 ct2034 added enhancement This tackles a new feature of the code (and not a bug) ros2 PR tackling a ROS2 branch needs more work Someone has worked on this but more work is needed labels Jan 25, 2024
@nnarain
Copy link

nnarain commented Jun 20, 2024

Hey @russkel

This is something I'm interested in, any plans to complete the work here?

@russkel
Copy link
Author

russkel commented Jun 25, 2024

Hey @russkel

This is something I'm interested in, any plans to complete the work here?

Hello @nnarain, it absolutely is. Other priorities have prevented me from moving on this further. Hopefully some time will free up soonish. What particular part were you interested?

@nnarain
Copy link

nnarain commented Jun 26, 2024

At my company we are making the slow migration to ROS 2. Tools like this are a nice QoL during development and a lot of people are used to using rosdiagnostic command (we actually use the output for the ssh login text). Not something I can't do without for now, but definitively a nice to have. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This tackles a new feature of the code (and not a bug) needs more work Someone has worked on this but more work is needed ros2 PR tackling a ROS2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants