Update ssl logic for self signed certs #324
Conversation
| ssl_context.check_hostname = False | ||
| ssl_context.verify_mode = ssl.CERT_NONE | ||
| connector = TCPConnector(enable_cleanup_closed=True, ssl=ssl_context) | ||
| connector = TCPConnector(enable_cleanup_closed=True, ssl=False) |
There was a problem hiding this comment.
I don't have any devices running ssl so I'm not able to test. I could merge and hope for the best?
There was a problem hiding this comment.
Me neither, we could do that and comment on those tickets to see if it fixes.
Btw are those automated pr test failures normal?
There was a problem hiding this comment.
The original way is triggering hassio warning but works, the one presented here throws error as Dahua Cams, at least mine, are not capable of tlsv1.3 and it all ends in error
File "/usr/local/lib/python3.12/site-packages/aiohttp/connector.py", line 1084, in _wrap_create_connection raise ClientConnectorSSLError(req.connection_key, exc) from exc aiohttp.client_exceptions.ClientConnectorSSLError: Cannot connect to host 192.168.68.242:443 ssl:default [[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] ssl/tls alert handshake failure (_ssl.c:1000)]
There was a problem hiding this comment.
Released in https://github.com/rroller/dahua/releases/tag/0.9.61
Can you please give it a try
There was a problem hiding this comment.
Great, let me close this
This needs testing.
Should be able to pass
ssl=Falsefor aiohttp 3.7.4May Resolve:
#314
#316