Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ssl logic for self signed certs #324

Closed
wants to merge 1 commit into from
+1 −5
Closed

Update ssl logic for self signed certs #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions custom_components/dahua/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,7 @@ def __init__(self, hass: HomeAssistant, events: list, address: str, port: int, r
password: str, name: str, channel: int) -> None:
"""Initialize the coordinator."""
# Self signed certs are used over HTTPS so we'll disable SSL verification
ssl_context = ssl.create_default_context()
ssl_context.set_ciphers("DEFAULT")
ssl_context.check_hostname = False
ssl_context.verify_mode = ssl.CERT_NONE
connector = TCPConnector(enable_cleanup_closed=True, ssl=ssl_context)
connector = TCPConnector(enable_cleanup_closed=True, ssl=False)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any devices running ssl so I'm not able to test. I could merge and hope for the best?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither, we could do that and comment on those tickets to see if it fixes.

Btw are those automated pr test failures normal?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original way is triggering hassio warning but works, the one presented here throws error as Dahua Cams, at least mine, are not capable of tlsv1.3 and it all ends in error
File "/usr/local/lib/python3.12/site-packages/aiohttp/connector.py", line 1084, in _wrap_create_connection raise ClientConnectorSSLError(req.connection_key, exc) from exc aiohttp.client_exceptions.ClientConnectorSSLError: Cannot connect to host 192.168.68.242:443 ssl:default [[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] ssl/tls alert handshake failure (_ssl.c:1000)]

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged this #394

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Released in https://github.com/rroller/dahua/releases/tag/0.9.61

Can you please give it a try

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let me close this

self._session = ClientSession(connector=connector)

# The client used to communicate with Dahua devices
Expand Down
Loading