Print locations using line / col instead of offsets #1549
Conversation
| @@ -71,7 +71,7 @@ def copy(**options) | |||
|
|
|||
| # Returns a string representation of this location. | |||
| def inspect | |||
| "#<YARP::Location @start_offset=#{@start_offset} @length=#{@length}>" | |||
| "#<YARP::Location @start_offset=#{@start_offset} @length=#{@length} start_line=#{start_line}>" | |||
There was a problem hiding this comment.
This change I'm slightly unsure of, since start_line is not an instance variable. However, this output seems helpful to me for cases like printing error messages.
There was a problem hiding this comment.
It's only debug code, I think it's fine.
jemmaissroff
force-pushed
the
line-col
branch
from
3e350f0 to
38cd4a9
Compare
This commit changes printing of locations to use the format (start_line,start_column)-(end_line,end_column) instead of using offsets.
jemmaissroff
force-pushed
the
line-col
branch
from
38cd4a9 to
c078696
Compare
|
A more concise format that RubyVM::AST uses is Columns are currently in number of bytes, that seems the case for RubyVM::AST too. |
|
@jemmaissroff could you look into the memcheck failure? Weird that it's failing on this, but I'm hoping it's surfacing something we can fix. I've found spin to be the best way to get access to valgrind. |
This commit changes printing of locations to use the format (start_line,start_column)-(end_line,end_column) instead of using offsets.