mshv-ioctls: Add support for aarch64 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
liuw
reviewed
Mar 25, 2024
|
@jinankjain This PR excludes some of the registers. After excluding the registers, rest of them are enough to boot arm64 guest? Don't we need additional registers somewhere? |
|
I have just added a compilation support not functional support for ARM64. get and set_reg would have a different implementation for aarch64. |
NunoDasNeves
requested changes
Mar 26, 2024
Remove conditional compilation for x86_64. Signed-off-by: Jinank Jain <[email protected]>
Since 32-bit ARM virtualization is not supported by MSHV. Thus, remove the check for it as well. Signed-off-by: Jinank Jain <[email protected]>
NunoDasNeves
approved these changes
Mar 28, 2024
russell-islam
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Remove conditional compilation for x86_64.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.