Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 16 and 19 after EOL #216

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

sbonami
Copy link
Owner

@sbonami sbonami commented Sep 14, 2023

Summary

Remove Node.js 16 and Node.js 19 after EOL

Test plan

CI/CD FTW!

@sbonami sbonami marked this pull request as draft September 14, 2023 00:41
@sbonami sbonami force-pushed the fix-remove-node16-after-eol branch from 2a5f930 to 58f83dc Compare September 18, 2023 01:06
@sbonami
Copy link
Owner Author

sbonami commented Sep 18, 2023

Awaiting tsconfig/bases#174 to resolve lib issue

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@sbonami sbonami marked this pull request as ready for review September 18, 2023 01:10
"compilerOptions": {
// From @tsconfig/node18/tsconfig.json except lib
// TODO: replace after https://github.com/tsconfig/bases/issues/174
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO found

@codeclimate
Copy link

codeclimate bot commented Sep 18, 2023

Code Climate has analyzed commit 58f83dc and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 1

View more on Code Climate.

@sbonami sbonami merged commit 1e63459 into main Sep 18, 2023
24 of 25 checks passed
@sbonami sbonami deleted the fix-remove-node16-after-eol branch September 18, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant