Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 16 and 19 after EOL #216

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Remove node 16 and 19 after EOL #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x, 19.x, 20.x]
node-version: [18.x, 20.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -152,7 +152,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x, 19.x, 20.x]
node-version: [18.x, 20.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x, 17.x, 18.x, 19.x, 20.x]
node-version: [18.x, 20.x]
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
14 changes: 8 additions & 6 deletions .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file removed .yarn/cache/@tsconfig-node16-npm-16.1.0-058e6fabe7-a0a176492e.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@tsconfig-node18-npm-18.2.2-659635cc4d-1c4b04b570.zip
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion constraints.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ gen_enforced_field(WorkspaceCwd, 'publishConfig.provenance', null) :-
workspace_field(WorkspaceCwd, 'private', true).

% Enforces the engines.node field for public workspace
gen_enforced_field(WorkspaceCwd, 'engines.node', '>=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0') :-
gen_enforced_field(WorkspaceCwd, 'engines.node', '>=18.0.0 || >=20.0.0') :-
\+ workspace_field(WorkspaceCwd, 'private', true).

% Enforces the main and types field to start with ./
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"pkg:publish": "lerna publish"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"packageManager": "[email protected]",
"workspaces": [
Expand All @@ -31,7 +31,7 @@
"@commitlint/cli": "^17.7.1",
"@commitlint/config-conventional": "^17.7.0",
"@commitlint/types": "^17.4.4",
"@tsconfig/node16": "^16.1.0",
"@tsconfig/node18": "^18.2.2",
"@types/jest": "^29.5.3",
"@types/node": "^20.5.0",
"@typescript-eslint/eslint-plugin": "^6.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/milliejs-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"typescript": "^4.9.5"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/milliejs-jest-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"jest": "^29.6.2"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/milliejs-store-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@milliejs/core": "workspace:^"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/milliejs-store-filesystem/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@milliejs/store-memory": "workspace:^"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/milliejs-store-google-pubsub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"typescript": "^4.9.5"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/milliejs-store-memory/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"tiny-invariant": "^1.3.1"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/milliejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@types/node": "^20.5.0"
},
"engines": {
"node": ">=16.0.0 || >=18.0.0 || >=19.0.0 || >=20.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
16 changes: 13 additions & 3 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
{
"extends": "@tsconfig/node16/tsconfig.json",
// "extends": "@tsconfig/node18/tsconfig.json",
"compilerOptions": {
// From @tsconfig/node18/tsconfig.json except lib
// TODO: replace after https://github.com/tsconfig/bases/issues/174
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO found

"lib": ["esnext"],
"module": "node16",
"target": "es2022",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node16",


// build entire project tree
"composite": true,
// output build cache
Expand All @@ -14,8 +26,6 @@
// linter checks for common issues
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
// use Node's module resolution algorithm, instead of the legacy TS one
"moduleResolution": "node16",

// error out if type-only imports are used as values
"importsNotUsedAsValues": "error"
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@ __metadata:
"@commitlint/cli": ^17.7.1
"@commitlint/config-conventional": ^17.7.0
"@commitlint/types": ^17.4.4
"@tsconfig/node16": ^16.1.0
"@tsconfig/node18": ^18.2.2
"@types/jest": ^29.5.3
"@types/node": ^20.5.0
"@typescript-eslint/eslint-plugin": ^6.4.0
Expand Down Expand Up @@ -1891,10 +1891,10 @@ __metadata:
languageName: node
linkType: hard

"@tsconfig/node16@npm:^16.1.0":
version: 16.1.0
resolution: "@tsconfig/node16@npm:16.1.0"
checksum: a0a176492e3802a5340eda1e61eabc8d4767e46496bc080ce9c381993ce8c5fb3df8f65267c3a9af4335bc00a85028845f795ea27545f63d62b93ab6675cf8fa
"@tsconfig/node18@npm:^18.2.2":
version: 18.2.2
resolution: "@tsconfig/node18@npm:18.2.2"
checksum: 1c4b04b570e33de14bf518492e077079db2dcfba738c8d40c6ff916d94c9410246f4cb56f0802d9771423862140bf714c35d4a5f6cec2446d851cf61d3f8f9df
languageName: node
linkType: hard

Expand Down
Loading