Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable installs now respect the value of wheel.install-dir #867

Merged
merged 11 commits into from
Aug 20, 2024

Change test to import the C module

ff924db
Select commit
Loading
Failed to load commit list.
Merged

Editable installs now respect the value of wheel.install-dir #867

Change test to import the C module
ff924db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2024 in 1s

83.98% (+0.07%) compared to 8cbd92f

View this Pull Request on Codecov

83.98% (+0.07%) compared to 8cbd92f

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.98%. Comparing base (8cbd92f) to head (ff924db).
Report is 1 commits behind head on main.

Files Patch % Lines
src/scikit_build_core/build/wheel.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   83.91%   83.98%   +0.07%     
==========================================
  Files          74       74              
  Lines        4363     4372       +9     
==========================================
+ Hits         3661     3672      +11     
+ Misses        702      700       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.