This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
AWS polish #117
Merged
AWS polish #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not supplying the Verifier and Encrypter at creation, it is now possible to embed a Key in a KeyCreator. This has the added benefit that a KeyCreator also implements the Provider interface. This is needed for creating a user and directly creating an AccountKey afterwards.
io.Reader suggests that it allows streaming. However, we do not want streaming when reading these small files. It adds a lot of unnecessary complexity. Therefore we chose to use a custom Reader interface that does not imply any streaming functionality.
With the addition of ConfigDir to Client, it is now possible to determine the default credential completely in the client. That way the credentials package does not have to know about the current configuration directory and can remain stateless.
golangcibot
reviewed
Aug 27, 2019
golangcibot
reviewed
Aug 27, 2019
Again, this name suffers from the complexity that it isn't the 'default' per se: it also allows configuration from the environment. It is more the default way to get a credential than that it is the default credential itself. Small but important difference in meaning. We'll leave it as is for now and may revisit it later.
mackenbach
reviewed
Aug 27, 2019
Otherwise the later == nil check fails. Woopsie.
…nto feature/aws-polish
As it no longer returns a string
mackenbach
approved these changes
Aug 28, 2019
There is no need to change this. Therefore making it private and only accessible through Path() makes more sense.
Fingerprint and the bytes of a verifier are always used together and both functions need each other. Therefore it makes sense to have one function that retrieves both. This makes using it a lot easier.
This was necessary because of the previous commit Export() was used twice. Encode() makes more sense anyway because that is exactly what this method does.
Export verifier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final changes to make the new client usable with the CLI.