AWS polish

pkg/secrethub/credentials/encoding.go

@@ -50,7 +50,7 @@ type EncodableCredential interface {
 type encodedCredential struct {
 	// Raw is the raw credential string.
 	// Populated when you Parse a credential.
-	Raw string
+	Raw []byte
 	// Header is the decoded first part of the credential string.
 	Header map[string]interface{}
 	// RawHeader is the first part of the credential string, encoded as json.
@@ -168,8 +168,8 @@ func newParser(decoders []Decoder) parser {
 }
 
 // parse parses a credential string.
-func (p parser) parse(raw string) (*encodedCredential, error) {
-	parts := strings.Split(raw, ".")
+func (p parser) parse(raw []byte) (*encodedCredential, error) {
+	parts := strings.Split(string(raw), ".")
 	if len(parts) != 2 {
 		return nil, ErrInvalidNumberOfCredentialSegments(len(parts))
 	}

pkg/secrethub/credentials/encoding_test.go

@@ -126,7 +126,7 @@ func TestParser(t *testing.T) {
 		"valid_rsa": {
 			raw: raw,
 			expected: &encodedCredential{
-				Raw:                 raw,
+				Raw:                 []byte(raw),
 				Header:              header,
 				RawHeader:           headerBytes,
 				Payload:             payload,
@@ -138,7 +138,7 @@ func TestParser(t *testing.T) {
 		"valid_rsa_encrypted": {
 			raw: rawEncrypted,
 			expected: &encodedCredential{
-				Raw:                 rawEncrypted,
+				Raw:                 []byte(rawEncrypted),
 				Header:              headerEncrypted,
 				RawHeader:           headerEncryptedBytes,
 				Payload:             payload,
@@ -209,7 +209,7 @@ func TestParser(t *testing.T) {
 	for name, tc := range cases {
 		t.Run(name, func(t *testing.T) {
 			// Act
-			actual, err := parser.parse(tc.raw)
+			actual, err := parser.parse([]byte(tc.raw))
 
 			// Assert
 			assert.Equal(t, err, tc.err)

pkg/secrethub/credentials/key.go

@@ -60,7 +60,7 @@ func readKey(credentialReader, passphraseReader Reader) (Key, error) {
 	if err != nil {
 		return Key{}, err
 	}
-	encoded, err := defaultParser.parse(string(bytes))
+	encoded, err := defaultParser.parse(bytes)
 	if err != nil {
 		return Key{}, err
 	}