fix,doc: condition of the max number of 1s inside a shape. #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3243 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 269 269
Lines 11856 11856
=======================================
Hits 11640 11640
Misses 216 216 ☔ View full report in Codecov by Sentry. |
eseiler
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a documentation issue that showed up in issue: #3242
The Attention box describes the number of 1s inside an shape. The condition is the wrong way. They described the
rejection criteria, not the accept criteria:
https://docs.seqan.de/seqan3/3.4.0/group__search__views.html#ga6e598d6a021868f704d39df73252974f