Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide virtual pools in Thorchain LP "Available Pools" view #6138

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 6, 2024

Description

Makes things cleaner and less bloated.

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

None

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • "Available Pools" only contains one pool per pool, without the two virtual asym variants
  • "Your Positions" contains your active positions, with the asym variants

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

image image

@gomesalexandre gomesalexandre marked this pull request as ready for review February 6, 2024 22:15
@gomesalexandre gomesalexandre requested a review from a team as a code owner February 6, 2024 22:15
@gomesalexandre gomesalexandre force-pushed the feat_available_pools_hide_virtual_pools branch from 9314306 to 0af6600 Compare February 7, 2024 14:08
@gomesalexandre gomesalexandre enabled auto-merge (squash) February 7, 2024 19:41
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much less bloated ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants