-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thorchain lp disable smart contract deposits #6177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2024
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
0xApotheosis
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gomesalexandre
force-pushed
the
thor_lp_smart_deposits
branch
from
February 13, 2024 00:05
92e5f18
to
a75ce30
Compare
gomesalexandre
force-pushed
the
feat_query_key_factory_shenanigans
branch
from
February 13, 2024 00:08
081e94a
to
1ce9785
Compare
gomesalexandre
force-pushed
the
thor_lp_smart_deposits
branch
3 times, most recently
from
February 14, 2024 00:11
2df5d21
to
2cbf4da
Compare
kaladinlight
approved these changes
Feb 14, 2024
kaladinlight
approved these changes
Feb 15, 2024
Base automatically changed from
feat_query_key_factory_shenanigans
to
develop
February 16, 2024 08:56
gomesalexandre
force-pushed
the
thor_lp_smart_deposits
branch
from
February 16, 2024 09:01
3941bef
to
2d23c00
Compare
gomesalexandre
force-pushed
the
thor_lp_smart_deposits
branch
from
February 16, 2024 09:02
2d23c00
to
92c2f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces smart contract checks for THORChain LP deposits.
Pull Request Type
Issue (if applicable)
closes #6107
Risk
Low from a theoretical perspective, high as we should ensure that
THORChain smart contracts
Testing
Engineering
Operations
Screenshots (if applicable)