Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fish completion #1222

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

magnuswatn
Copy link
Contributor

Fish completion doesn't work, since a nil error is printed after the completion:

❯ ./bin/step completion fish | tail -n 2
complete -c step -n '__fish_seen_subcommand_from revoke' -f -l context -r -d 'The context <name> to apply for the given command.'
<nil>⏎      

❯ ./bin/step completion fish | source
- (line 3899): Expected a string, but found a redirection
<nil>
^
from sourcing file -
source: Error while reading file '<stdin>'                                                                                                                                                                                                                                         

So handle the error instead of printing it.

`ToFishCompletion()` returns an error that needs to be handled.
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jun 29, 2024
@hslatman hslatman added this to the v0.26.3 milestone Jul 1, 2024
@hslatman
Copy link
Member

hslatman commented Jul 1, 2024

Thank you, @magnuswatn 🙂

@hslatman hslatman merged commit a337925 into smallstep:master Jul 1, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants