Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fish completion #1222

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix fish completion #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion command/completion/completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@
case "zsh":
fmt.Print(zsh)
case "fish":
fmt.Print(ctx.App.ToFishCompletion())
fish, err := ctx.App.ToFishCompletion()
if err != nil {
return fmt.Errorf("error creating fish completion: %w", err)

Check warning on line 113 in command/completion/completion.go

View check run for this annotation

Codecov / codecov/patch

command/completion/completion.go#L111-L113 

Added lines #L111 - L113 were not covered by tests
}
fmt.Print(fish)

Check warning on line 115 in command/completion/completion.go

View check run for this annotation

Codecov / codecov/patch

command/completion/completion.go#L115 

Added line #L115 was not covered by tests
default:
return errors.Errorf("unsupported shell %s", shell)
}
Expand Down