Added stack bound for const calculations. #6989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2025
|
This change is |
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
from
45b2ddd to
0bcd969
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
2 times, most recently
from
379ba79 to
e15e888
Compare
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
from
0bcd969 to
48861ce
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
e15e888 to
9aa0f77
Compare
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
2 times, most recently
from
2b9e4ed to
1b3334a
Compare
This was referenced Jan 5, 2025
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
from
1b3334a to
d29a0e5
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
2 times, most recently
from
c40675a to
ced3c81
Compare
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
2 times, most recently
from
ff301c7 to
5ef0fd0
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
ced3c81 to
907bbe6
Compare
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
2 times, most recently
from
a5fd8dd to
c27997c
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
0a85e5c to
0e4f43f
Compare
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
2 times, most recently
from
d138aa9 to
ac80faa
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
8497b09 to
055d3ef
Compare
TomerStarkware
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
commit-id:f8cbd2f9
orizi
force-pushed
the
spr/main/f8cbd2f9
branch
from
ac80faa to
a0d79b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
powin constant eval. #6996div_rem. #6995!for const evaluation. #6994==!=<<=>and>=in const eval. #6993