Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for const eval div_rem. #6995

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Added support for const eval div_rem. #6995

merged 1 commit into from
Jan 6, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 5, 2025

Required minor refactoring of args handling.


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the spr/main/e185f290 branch from ccb6fbf to 04c770e Compare January 5, 2025 11:02
@orizi orizi force-pushed the spr/main/73bf14cd branch from 41b6533 to 3e1be6c Compare January 5, 2025 11:03
@orizi orizi force-pushed the spr/main/e185f290 branch 2 times, most recently from 9909a47 to 42b9426 Compare January 5, 2025 15:46
@orizi orizi force-pushed the spr/main/73bf14cd branch from 0033c1e to 8c5fdd5 Compare January 5, 2025 15:46
@orizi orizi force-pushed the spr/main/e185f290 branch 2 times, most recently from eaa515a to 2b2edae Compare January 5, 2025 16:30
@orizi orizi force-pushed the spr/main/73bf14cd branch from 25ae532 to 6846bcb Compare January 5, 2025 16:30
@orizi orizi force-pushed the spr/main/e185f290 branch from 2b2edae to 7bcf742 Compare January 5, 2025 16:52
@orizi orizi force-pushed the spr/main/73bf14cd branch from 6846bcb to b7c6e77 Compare January 5, 2025 16:52
@orizi orizi force-pushed the spr/main/e185f290 branch from 7bcf742 to 35ad7da Compare January 5, 2025 19:14
@orizi orizi force-pushed the spr/main/73bf14cd branch from 0b1ff57 to bac761e Compare January 6, 2025 04:14
@orizi orizi force-pushed the spr/main/e185f290 branch from 35ad7da to 5527c22 Compare January 6, 2025 04:14
@orizi orizi force-pushed the spr/main/73bf14cd branch from bac761e to 87aa3cd Compare January 6, 2025 04:30
@orizi orizi force-pushed the spr/main/e185f290 branch 2 times, most recently from 745cd24 to d0f21b4 Compare January 6, 2025 05:24
@orizi orizi force-pushed the spr/main/73bf14cd branch from 87aa3cd to c7dbf6f Compare January 6, 2025 05:24
Required minor refactoring of args handling.

commit-id:e185f290
@orizi orizi force-pushed the spr/main/e185f290 branch from d0f21b4 to 6025b75 Compare January 6, 2025 05:45
@orizi orizi changed the base branch from spr/main/73bf14cd to main January 6, 2025 05:45
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 2ac3e65 Jan 6, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants