-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for const eval div_rem
.
#6995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2025
orizi
force-pushed
the
spr/main/e185f290
branch
from
January 5, 2025 11:02
ccb6fbf
to
04c770e
Compare
orizi
force-pushed
the
spr/main/73bf14cd
branch
from
January 5, 2025 11:03
41b6533
to
3e1be6c
Compare
orizi
force-pushed
the
spr/main/e185f290
branch
2 times, most recently
from
January 5, 2025 15:46
9909a47
to
42b9426
Compare
orizi
force-pushed
the
spr/main/73bf14cd
branch
from
January 5, 2025 15:46
0033c1e
to
8c5fdd5
Compare
orizi
force-pushed
the
spr/main/e185f290
branch
2 times, most recently
from
January 5, 2025 16:30
eaa515a
to
2b2edae
Compare
orizi
force-pushed
the
spr/main/73bf14cd
branch
from
January 5, 2025 16:30
25ae532
to
6846bcb
Compare
orizi
force-pushed
the
spr/main/e185f290
branch
from
January 5, 2025 16:52
2b2edae
to
7bcf742
Compare
orizi
force-pushed
the
spr/main/73bf14cd
branch
from
January 5, 2025 16:52
6846bcb
to
b7c6e77
Compare
orizi
force-pushed
the
spr/main/e185f290
branch
from
January 5, 2025 19:14
7bcf742
to
35ad7da
Compare
orizi
force-pushed
the
spr/main/73bf14cd
branch
from
January 6, 2025 04:14
0b1ff57
to
bac761e
Compare
orizi
force-pushed
the
spr/main/e185f290
branch
from
January 6, 2025 04:14
35ad7da
to
5527c22
Compare
orizi
force-pushed
the
spr/main/73bf14cd
branch
from
January 6, 2025 04:30
bac761e
to
87aa3cd
Compare
orizi
force-pushed
the
spr/main/e185f290
branch
2 times, most recently
from
January 6, 2025 05:24
745cd24
to
d0f21b4
Compare
orizi
force-pushed
the
spr/main/73bf14cd
branch
from
January 6, 2025 05:24
87aa3cd
to
c7dbf6f
Compare
Required minor refactoring of args handling. commit-id:e185f290
orizi
force-pushed
the
spr/main/e185f290
branch
from
January 6, 2025 05:45
d0f21b4
to
6025b75
Compare
TomerStarkware
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required minor refactoring of args handling.
Stack:
pow
in constant eval. #6996div_rem
. #6995 ⬅