Add restic wrapper library #673

hossainemruz · 2019-02-14T04:37:21Z

Requirements:

Merge Introduce v1beta1 api #647 to master
Rebase against master

codecov-io · 2019-02-14T04:47:04Z

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #673   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines           8      8           
=====================================
  Hits            8      8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8309a...09cdd49. Read the comment docs.

pkg/restic/output.go

pkg/restic/config.go

pkg/restic/commands.go

tamalsaha · 2019-03-19T05:08:50Z

pkg/util/options.go

+
+// return first matching rule
+// if hosts is empty for any rule, it will match any hostname
+func RestoreOptionsForHost(hostname string, rules []api.Rule) restic.RestoreOptions {


# Conflicts: # glide.lock # vendor/github.com/go-openapi/swag/loading.go # vendor/github.com/go-openapi/swag/util.go # vendor/github.com/go-openapi/swag/yaml.go # vendor/github.com/google/go-cmp/cmp/compare.go # vendor/github.com/google/go-cmp/cmp/options.go # vendor/github.com/google/go-cmp/cmp/path.go # vendor/github.com/google/go-cmp/cmp/reporter.go

tamalsaha · 2019-03-19T05:24:57Z

pkg/restic/util.go

+	"github.com/pkg/errors"
+)
+
+func convertToMinutesSeconds(time string) (int, int, error) {


Find out how restic generates the output format.

tamalsaha · 2019-03-19T05:28:35Z

pkg/restic/util.go

+	return r == ' ' || r == '\t' || r == ','
+}
+
+func convertSizeToBytes(dataSize string) (float64, error) {


https://github.com/dustin/go-humanize ?

- [x] Merge #647 - [x] Merge #673 **Notes** - Implicit inputs are collected from backup/restore session, backup config and repositories. For current list see `inputs.go`. - Inputs to tasks are carried over to functions. - Inputs for resolving tasks: implicit inputs + backup config params - Inputs for resolving functions: inputs to parent task + task params - Host name: `host-0` - `drone/envsubst` only works with alphanumeric characters and underscore as key name.

**Requirements:** - [x] Merge #647 to master - [x] Merge #673 to master - [x] Merge #674 to master - [x] Merge #671 to master - [x] Rebase against master **Tasks:** - [x] Update Restore Logic - [x] Update Backup Logic - [x] Update Workload Controllers - [x] Deployment - [x] DaemonSet - [x] ReplicationControler - [x] ReplicaSet - [x] StatefulSet - [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic - [x] Ensure sidecar/init-container according to new design - [x] Ensure Restore init-container injection - [x] Ensure Restore init-container deletion - [x] Ensure Backup sidecar injection - [x] Ensure Backup sidecar deletion - [x] Add new backup command (sagor is working) - [x] Add new restore command - [x] Add controller (possibly in different PR) - [x] PersistentVolumeClaim - [x] AppBinding

**Requirements** : - [x] Merge #673 to master - [x] Merge #675 to master - [x] Merge #691 - [x] Rebase against master **Fixed Issue** : - [x] Add `BackupSession Sidecar Controller` Controller - [x] Controller take backup

**Requirements:** - [x] Merge stashed/stash#647 to master - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#674 to master - [x] Merge stashed/stash#671 to master - [x] Rebase against master **Tasks:** - [x] Update Restore Logic - [x] Update Backup Logic - [x] Update Workload Controllers - [x] Deployment - [x] DaemonSet - [x] ReplicationControler - [x] ReplicaSet - [x] StatefulSet - [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic - [x] Ensure sidecar/init-container according to new design - [x] Ensure Restore init-container injection - [x] Ensure Restore init-container deletion - [x] Ensure Backup sidecar injection - [x] Ensure Backup sidecar deletion - [x] Add new backup command (sagor is working) - [x] Add new restore command - [x] Add controller (possibly in different PR) - [x] PersistentVolumeClaim - [x] AppBinding

**Requirements** : - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#675 to master - [x] Merge stashed/stash#691 - [x] Rebase against master **Fixed Issue** : - [x] Add `BackupSession Sidecar Controller` Controller - [x] Controller take backup

**Requirements:** - [x] Merge stashed/stash#647 to master - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#674 to master - [x] Merge stashed/stash#671 to master - [x] Rebase against master **Tasks:** - [x] Update Restore Logic - [x] Update Backup Logic - [x] Update Workload Controllers - [x] Deployment - [x] DaemonSet - [x] ReplicationControler - [x] ReplicaSet - [x] StatefulSet - [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic - [x] Ensure sidecar/init-container according to new design - [x] Ensure Restore init-container injection - [x] Ensure Restore init-container deletion - [x] Ensure Backup sidecar injection - [x] Ensure Backup sidecar deletion - [x] Add new backup command (sagor is working) - [x] Add new restore command - [x] Add controller (possibly in different PR) - [x] PersistentVolumeClaim - [x] AppBinding

**Requirements** : - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#675 to master - [x] Merge stashed/stash#691 - [x] Rebase against master **Fixed Issue** : - [x] Add `BackupSession Sidecar Controller` Controller - [x] Controller take backup

**Requirements:** - [x] Merge stashed/stash#647 to master - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#674 to master - [x] Merge stashed/stash#671 to master - [x] Rebase against master **Tasks:** - [x] Update Restore Logic - [x] Update Backup Logic - [x] Update Workload Controllers - [x] Deployment - [x] DaemonSet - [x] ReplicationControler - [x] ReplicaSet - [x] StatefulSet - [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic - [x] Ensure sidecar/init-container according to new design - [x] Ensure Restore init-container injection - [x] Ensure Restore init-container deletion - [x] Ensure Backup sidecar injection - [x] Ensure Backup sidecar deletion - [x] Add new backup command (sagor is working) - [x] Add new restore command - [x] Add controller (possibly in different PR) - [x] PersistentVolumeClaim - [x] AppBinding

**Requirements** : - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#675 to master - [x] Merge stashed/stash#691 - [x] Rebase against master **Fixed Issue** : - [x] Add `BackupSession Sidecar Controller` Controller - [x] Controller take backup

hossainemruz requested review from tamalsaha and diptadas February 14, 2019 04:37

hossainemruz force-pushed the restic-wrapper branch from b2544e4 to c65aa3a Compare February 20, 2019 08:39

hossainemruz mentioned this pull request Feb 20, 2019

Update workload controller for new design #675

Merged

24 tasks

hossainemruz force-pushed the restic-wrapper branch from 2d82625 to e062655 Compare February 25, 2019 05:39

diptadas previously approved these changes Feb 25, 2019

View reviewed changes

hossainemruz dismissed diptadas’s stale review via b953ae9 February 26, 2019 04:13

hossainemruz force-pushed the restic-wrapper branch from e062655 to b953ae9 Compare February 26, 2019 04:13

hossainemruz added 2 commits February 27, 2019 16:37

Add restic wrapper library

910b9a8

remove conflict with master

47694c1

hossainemruz force-pushed the restic-wrapper branch from b953ae9 to 47694c1 Compare February 27, 2019 10:48

diptadas suggested changes Feb 28, 2019

View reviewed changes

pkg/restic/output.go Outdated Show resolved Hide resolved

pkg/restic/output.go Outdated Show resolved Hide resolved

pkg/restic/output.go Outdated Show resolved Hide resolved

pkg/restic/output.go Outdated Show resolved Hide resolved

diptadas reviewed Mar 1, 2019

View reviewed changes

pkg/restic/config.go Outdated Show resolved Hide resolved

diptadas suggested changes Mar 1, 2019

View reviewed changes

pkg/restic/commands.go Outdated Show resolved Hide resolved

hossainemruz force-pushed the restic-wrapper branch from ca429a1 to cf448a6 Compare March 4, 2019 04:21

hossainemruz requested a review from diptadas March 4, 2019 04:23

Update config and output

d1e102d

diptadas force-pushed the restic-wrapper branch from 575332a to c6db29e Compare March 5, 2019 11:07

Add helpers

b5173e9

diptadas force-pushed the restic-wrapper branch from c6db29e to b5173e9 Compare March 5, 2019 11:17

suaas21 mentioned this pull request Mar 13, 2019

Add BackupSession Controller for Sidecar #701

Merged

6 tasks

tamalsaha mentioned this pull request Mar 19, 2019

Add restic wrapper in tools kmodules/client-go#294

Closed

tamalsaha reviewed Mar 19, 2019

View reviewed changes

tamalsaha approved these changes Mar 19, 2019

View reviewed changes

tamalsaha merged commit 6a74602 into master Mar 19, 2019

tamalsaha deleted the restic-wrapper branch March 19, 2019 05:29

hossainemruz mentioned this pull request Mar 22, 2019

Add/Update Monitoring metrics #664

Closed

This was referenced Mar 28, 2019

Improve monitoring metrics #604

Open

Collect Prometheus stats for Recovery #214

Closed

Backup failed metrics not coming #595

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add restic wrapper library #673

Add restic wrapper library #673

hossainemruz commented Feb 14, 2019 •

edited

Loading

codecov-io commented Feb 14, 2019 •

edited

Loading

tamalsaha Mar 19, 2019

tamalsaha Mar 19, 2019

tamalsaha Mar 19, 2019

Add restic wrapper library #673

Add restic wrapper library #673

Conversation

hossainemruz commented Feb 14, 2019 • edited Loading

codecov-io commented Feb 14, 2019 • edited Loading

Codecov Report

tamalsaha Mar 19, 2019

Choose a reason for hiding this comment

tamalsaha Mar 19, 2019

Choose a reason for hiding this comment

tamalsaha Mar 19, 2019

Choose a reason for hiding this comment

hossainemruz commented Feb 14, 2019 •

edited

Loading

codecov-io commented Feb 14, 2019 •

edited

Loading