feat: SIGNAL-7190 Task.await_many for batch operations #110
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerd
approved these changes
Oct 18, 2024
|
Note to self: test this one more round locally before merging |
seungjinstord
pushed a commit
that referenced
this pull request
Oct 21, 2024
An automated release has been created for you. --- ## [3.4.0](v3.3.1...v3.4.0) (2024-10-18) ### Features * SIGNAL-7190 Task.await_many for batch operations ([#110](#110)) ([79c9f42](79c9f42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
SIGNAL-7190
Checklist
Problem
Task.async operations to finish before finishing up the batch because it’s “going too fast” and DB can’t keep up (afraid same thing might happen in prod).
Details
We’ll use Task.await_many as the back pressure, as that delays batching function to finish, and increasing the time to finish is the back pressure onto receiving more messages.