Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SIGNAL-7190 Task.await_many for batch operations #110

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/kafee/consumer/broadway_adapter.ex
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ defmodule Kafee.Consumer.BroadwayAdapter do
if batch_config[:async_run] do
# No need for Task.Supervisor as it is not running under a GenServer,
# and Kafee.Consumer.Adapter.push_message does already have error handling.
Enum.each(messages, &Task.async(fn -> do_consumer_work(&1, consumer, options) end))
tasks = Enum.map(messages, &Task.async(fn -> do_consumer_work(&1, consumer, options) end))
Task.await_many(tasks)
else
Enum.each(messages, fn message -> do_consumer_work(message, consumer, options) end)
end
Expand Down