-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change ArgumentList name to FuncParameterList #79
Conversation
Mostly cleanup and renaming of variables before introducing function return type derivation |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 59.41% 59.58% +0.16%
==========================================
Files 43 43
Lines 9221 9314 +93
==========================================
+ Hits 5479 5550 +71
- Misses 3497 3505 +8
- Partials 245 259 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changed lines have no coverage but that's not related to this name change PR.
3e7b759
to
402419f
Compare
This should have a breaking change commit message, right? |
Updated the PR title and description. |
Fixed bugs in matching variadic arguments.
BREAKING CHANGE:
ArgumentList
has been renamed toFuncParameterList
.BREAKING CHANGE:
ReturnType
method in theFuncDefArgType
interface now requiresFuncParameterList
and actual argument types as parameters.