Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change ArgumentList name to FuncParameterList #79

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

scgkiran
Copy link
Contributor

@scgkiran scgkiran commented Nov 29, 2024

Fixed bugs in matching variadic arguments.

BREAKING CHANGE:

  • ArgumentList has been renamed to FuncParameterList.

BREAKING CHANGE:

  • The ReturnType method in the FuncDefArgType interface now requires FuncParameterList and actual argument types as parameters.

@scgkiran
Copy link
Contributor Author

scgkiran commented Nov 29, 2024

Mostly cleanup and renaming of variables before introducing function return type derivation

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 66 lines in your changes missing coverage. Please review.

Project coverage is 59.58%. Comparing base (c7fc536) to head (402419f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
types/types.go 37.93% 33 Missing and 3 partials ⚠️
extensions/simple_extension.go 22.72% 17 Missing ⚠️
extensions/variants.go 75.51% 9 Missing and 3 partials ⚠️
types/any_type.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   59.41%   59.58%   +0.16%     
==========================================
  Files          43       43              
  Lines        9221     9314      +93     
==========================================
+ Hits         5479     5550      +71     
- Misses       3497     3505       +8     
- Partials      245      259      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

extensions/simple_extension.go Show resolved Hide resolved
extensions/variants.go Outdated Show resolved Hide resolved
types/types.go Show resolved Hide resolved
types/parameterized_list_type_test.go Outdated Show resolved Hide resolved
types/types.go Show resolved Hide resolved
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the changed lines have no coverage but that's not related to this name change PR.

@jacques-n
Copy link
Contributor

This should have a breaking change commit message, right?

@scgkiran scgkiran changed the title chore: change ArgumentList name to FuncParameterList feat: change ArgumentList name to FuncParameterList Dec 3, 2024
@scgkiran
Copy link
Contributor Author

scgkiran commented Dec 3, 2024

This should have a breaking change commit message, right?

Updated the PR title and description.

@jacques-n jacques-n merged commit 9b453f5 into substrait-io:main Dec 3, 2024
7 of 8 checks passed
@scgkiran scgkiran deleted the func_parameters branch December 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants