Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support function return type derivation #80

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

scgkiran
Copy link
Contributor

@scgkiran scgkiran commented Dec 1, 2024

No description provided.

@scgkiran scgkiran marked this pull request as draft December 1, 2024 14:55
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 78.47534% with 96 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (9b453f5) to head (669326c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
types/parser/type_derivation.go 79.27% 39 Missing and 7 partials ⚠️
types/types.go 65.00% 14 Missing ⚠️
types/parameterized_struct_type.go 43.75% 6 Missing and 3 partials ⚠️
types/any_type.go 74.07% 6 Missing and 1 partial ⚠️
types/parameterized_map_type.go 58.33% 4 Missing and 1 partial ⚠️
types/parameterized_list_type.go 50.00% 3 Missing and 1 partial ⚠️
types/parameterized_user_defined_type.go 73.33% 3 Missing and 1 partial ⚠️
types/parameterized_decimal_type.go 81.25% 3 Missing ⚠️
types/parameterized_single_integer_param_type.go 81.81% 2 Missing ⚠️
extensions/variants.go 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   59.56%   61.20%   +1.63%     
==========================================
  Files          43       44       +1     
  Lines        9316     9709     +393     
==========================================
+ Hits         5549     5942     +393     
+ Misses       3507     3491      -16     
- Partials      260      276      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scgkiran scgkiran force-pushed the output_derivation branch 2 times, most recently from 6c0a736 to 73dc958 Compare December 2, 2024 15:46
@scgkiran scgkiran marked this pull request as ready for review December 2, 2024 15:47
extensions/simple_extension.go Outdated Show resolved Hide resolved
types/any_type.go Outdated Show resolved Hide resolved
types/parameterized_decimal_type.go Show resolved Hide resolved
types/parameterized_list_type.go Show resolved Hide resolved
types/parameterized_user_defined_type.go Show resolved Hide resolved
types/parser/visitor.go Show resolved Hide resolved
@jacques-n jacques-n merged commit 82d4922 into substrait-io:main Dec 4, 2024
8 checks passed
@scgkiran scgkiran deleted the output_derivation branch December 4, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants