Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Component #2795

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

use label workaround

90fc87c
Select commit
Loading
Failed to load commit list.
Open

Modal Component #2795

use label workaround
90fc87c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 1s

87.83% (+0.08%) compared to 13dc329

View this Pull Request on Codecov

87.83% (+0.08%) compared to 13dc329

Details

Codecov Report

Attention: Patch coverage is 92.73743% with 26 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (13dc329) to head (90fc87c).

Files with missing lines Patch % Lines
packages/circuit-ui/components/Modal/Modal.tsx 86.04% 24 Missing ⚠️
...mponents/NotificationModal/useNotificationModal.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
+ Coverage   87.75%   87.83%   +0.08%     
==========================================
  Files         221      225       +4     
  Lines       12746    13004     +258     
  Branches     1730     1776      +46     
==========================================
+ Hits        11185    11422     +237     
- Misses       1506     1528      +22     
+ Partials       55       54       -1     
Files with missing lines Coverage Δ
...kages/circuit-ui/components/Modal/ModalContext.tsx 100.00% <100.00%> (ø)
...ckages/circuit-ui/components/Modal/ModalService.ts 100.00% <100.00%> (ø)
...ages/circuit-ui/components/Modal/createUseModal.ts 100.00% <100.00%> (ø)
...components/NotificationModal/NotificationModal.tsx 92.85% <100.00%> (-1.47%) ⬇️
...es/circuit-ui/hooks/useScrollLock/useScrollLock.ts 100.00% <100.00%> (ø)
packages/design-tokens/scripts/build.ts 94.63% <100.00%> (ø)
...mponents/NotificationModal/useNotificationModal.ts 0.00% <0.00%> (ø)
packages/circuit-ui/components/Modal/Modal.tsx 85.95% <86.04%> (-3.34%) ⬇️