This repository has been archived by the owner on Jun 14, 2019. It is now read-only.
Refactoring extension-related code to use hooks #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- converted React.Component to React.FunctionComponent - added notifications for successful and failed imports - i18n'd a few things - replaced WithExtensionHelpers with useExtensionHelpers
|
PR Storybook available here |
riccardo-forina
suggested changes
Jun 10, 2019
There was a problem hiding this comment.
So, in general, it looks ok but there is a lot of repetition in the useXyz hooks.
I have recently added a useApiResource hook that can be used to DRY the API related hooks. See a simple example here or a more advanced one here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/ui/Customization/extensionscode has been refactoredsyndesis/modules/extensionscode has been refactoredpackages/apicode (WithExtension,WithExtensions,WithExtensionIntegrations)