Add original_start_time to the workflow execution started event #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Dec 20, 2024
alexshtin
reviewed
Dec 20, 2024
yycptt
reviewed
Dec 20, 2024
| @@ -77,6 +77,10 @@ message WorkflowExecutionStartedEventAttributes { | |||
| // This is the run id when the WorkflowExecutionStarted event was written. | |||
| // A workflow reset changes the execution run_id, but preserves this field. | |||
| string original_execution_run_id = 14; | |||
| // This is the start time when the WorkflowExecutionStarted event was written. | |||
| // A workflow reset will change execution start time, but will preserve this field. | |||
| google.protobuf.Timestamp original_execution_start_time = 34; | |||
There was a problem hiding this comment.
Why do we need this? The event is reused across reset so start event time is the original execution start time.
There was a problem hiding this comment.
ok great. then we don't need this. closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add
original_execution_start_timefield toWorkflowExecutionStartedEventAttributes.Why?
To preserve original execution start time. It will be later used to populate extended info for workflow execution during
DescribeWorkflowcalls.