Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original_start_time to the workflow execution started event #507

Closed
wants to merge 4 commits into from
Closed

Add original_start_time to the workflow execution started event #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ebdf31
Add original_start_time to the workflow execution started event
ychebotarev Dec 20, 2024
b54b39c
openapi changes
ychebotarev Dec 20, 2024
9a47b72
group this field with original_run_id
ychebotarev Dec 20, 2024
7e2d30d
more openapi changes
ychebotarev Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions openapi/openapiv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13157,6 +13157,11 @@
"type": "string",
"description": "This is the run id when the WorkflowExecutionStarted event was written.\nA workflow reset changes the execution run_id, but preserves this field."
},
"originalExecutionStartTime": {
"type": "string",
"format": "date-time",
"description": "This is the start time when the WorkflowExecutionStarted event was written.\nA workflow reset will change execution start time, but will preserve this field."
},
"identity": {
"type": "string",
"title": "Identity of the client who requested this execution"
Expand Down
6 changes: 6 additions & 0 deletions openapi/openapiv3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10655,6 +10655,12 @@ components:
description: |-
This is the run id when the WorkflowExecutionStarted event was written.
A workflow reset changes the execution run_id, but preserves this field.
originalExecutionStartTime:
type: string
description: |-
This is the start time when the WorkflowExecutionStarted event was written.
A workflow reset will change execution start time, but will preserve this field.
format: date-time
identity:
type: string
description: Identity of the client who requested this execution
Expand Down
4 changes: 4 additions & 0 deletions temporal/api/history/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ message WorkflowExecutionStartedEventAttributes {
// This is the run id when the WorkflowExecutionStarted event was written.
// A workflow reset changes the execution run_id, but preserves this field.
string original_execution_run_id = 14;
// This is the start time when the WorkflowExecutionStarted event was written.
// A workflow reset will change execution start time, but will preserve this field.
google.protobuf.Timestamp original_execution_start_time = 34;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? The event is reused across reset so start event time is the original execution start time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok great. then we don't need this. closing


// Identity of the client who requested this execution
string identity = 15;
// This is the very first runId along the chain of ContinueAsNew, Retry, Cron and Reset.
Expand Down
Loading